Re: [ovs-dev] [PATCH] net: openvswitch: use do_div() for 64-by-32 divisions:

2020-04-24 Thread Tonghao Zhang
On Sat, Apr 25, 2020 at 1:54 AM Geert Uytterhoeven wrote: > > Hi Toke, > > On Fri, Apr 24, 2020 at 6:45 PM Toke Høiland-Jørgensen > wrote: > > Geert Uytterhoeven writes: > > > On Fri, Apr 24, 2020 at 5:05 PM Eric Dumazet > > > wrote: > > >> On 4/24/20 5:10 AM, Geert Uytterhoeven wrote: > > >>

Re: [ovs-dev] [PATCH] net: openvswitch: use do_div() for 64-by-32 divisions:

2020-04-24 Thread Geert Uytterhoeven
Hi Toke, On Fri, Apr 24, 2020 at 6:45 PM Toke Høiland-Jørgensen wrote: > Geert Uytterhoeven writes: > > On Fri, Apr 24, 2020 at 5:05 PM Eric Dumazet wrote: > >> On 4/24/20 5:10 AM, Geert Uytterhoeven wrote: > >> > On 32-bit architectures (e.g. m68k): > >> > > >> > ERROR: modpost: "__udivdi3

Re: [ovs-dev] [PATCH] net: openvswitch: use do_div() for 64-by-32 divisions:

2020-04-24 Thread Toke Høiland-Jørgensen
Geert Uytterhoeven writes: > Hi Eric, > > On Fri, Apr 24, 2020 at 5:05 PM Eric Dumazet wrote: >> On 4/24/20 5:10 AM, Geert Uytterhoeven wrote: >> > On 32-bit architectures (e.g. m68k): >> > >> > ERROR: modpost: "__udivdi3" [net/openvswitch/openvswitch.ko] undefined! >> > ERROR: modpost:

Re: [ovs-dev] [PATCH] net: openvswitch: use do_div() for 64-by-32 divisions:

2020-04-24 Thread Geert Uytterhoeven
Hi Eric, On Fri, Apr 24, 2020 at 5:05 PM Eric Dumazet wrote: > On 4/24/20 5:10 AM, Geert Uytterhoeven wrote: > > On 32-bit architectures (e.g. m68k): > > > > ERROR: modpost: "__udivdi3" [net/openvswitch/openvswitch.ko] undefined! > > ERROR: modpost: "__divdi3" [net/openvswitch/openvswitch

Re: [ovs-dev] [PATCH] net: openvswitch: use do_div() for 64-by-32 divisions:

2020-04-24 Thread Eric Dumazet
On 4/24/20 5:10 AM, Geert Uytterhoeven wrote: > On 32-bit architectures (e.g. m68k): > > ERROR: modpost: "__udivdi3" [net/openvswitch/openvswitch.ko] undefined! > ERROR: modpost: "__divdi3" [net/openvswitch/openvswitch.ko] undefined! > > Fixes: e57358873bb5d6ca ("net: openvswitch: use

[ovs-dev] [PATCH] net: openvswitch: use do_div() for 64-by-32 divisions:

2020-04-24 Thread Geert Uytterhoeven
On 32-bit architectures (e.g. m68k): ERROR: modpost: "__udivdi3" [net/openvswitch/openvswitch.ko] undefined! ERROR: modpost: "__divdi3" [net/openvswitch/openvswitch.ko] undefined! Fixes: e57358873bb5d6ca ("net: openvswitch: use u64 for meter bucket") Reported-by: nore...@ellerman.id.au Si