On 22.03.2018 11:05, Weglicki, MichalX wrote:
>
>
>> -Original Message-
>> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
>> Sent: Wednesday, March 21, 2018 3:07 PM
>> To: Weglicki, MichalX ; ovs-dev@openvswitch.org
>> Cc: Heetae Ahn ; Ben Pfaff ; Stokes,
>> Ian
>> Subject: Re: [PA
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Wednesday, March 21, 2018 3:07 PM
> To: Weglicki, MichalX ; ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Ben Pfaff ; Stokes,
> Ian
> Subject: Re: [PATCH] netdev-dpdk: Refactor custom stats.
>
> On 20.03.20
On Tue, Mar 20, 2018 at 09:35:17AM +, Weglicki, MichalX wrote:
> > -Original Message-
> > From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> > Sent: Tuesday, March 20, 2018 9:50 AM
> > To: Weglicki, MichalX ; ovs-dev@openvswitch.org
> > Cc: Heetae Ahn ; Ben Pfaff ;
> > Stokes, Ian
> On 20.03.2018 12:35, Weglicki, MichalX wrote:
> >> -Original Message-
> >> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> >> Sent: Tuesday, March 20, 2018 9:50 AM
> >> To: Weglicki, MichalX ;
> >> ovs-dev@openvswitch.org
> >> Cc: Heetae Ahn ; Ben Pfaff ;
> >> Stokes, Ian
> >> Subj
On 20.03.2018 12:35, Weglicki, MichalX wrote:
>> -Original Message-
>> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
>> Sent: Tuesday, March 20, 2018 9:50 AM
>> To: Weglicki, MichalX ; ovs-dev@openvswitch.org
>> Cc: Heetae Ahn ; Ben Pfaff ; Stokes,
>> Ian
>> Subject: Re: [PATCH] net
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Tuesday, March 20, 2018 9:50 AM
> To: Weglicki, MichalX ; ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Ben Pfaff ; Stokes,
> Ian
> Subject: Re: [PATCH] netdev-dpdk: Refactor custom stats.
>
> On 19.03.2018 1
On 19.03.2018 13:22, Weglicki, MichalX wrote:
> Hello,
Hello.
>
> I've went through the patch quite carefully.
Thanks for reviewing this.
> Main change refactors creation cached IDs and Names from IF-like code block
> to "Goto" code block.
Current code is over-nested. It has nesting level
Hello,
I've went through the patch quite carefully. Main change refactors creation
cached IDs and Names from IF-like code block to "Goto" code block.
There are also some initializations removal, which I don't personally agree
with - even if those seems to be not needed, code may always evolve
This code is overcomplicated and completely unreadable. And a
bunch of recently fixed memory leaks confirms that statement.
Main concerns that were fixed:
* Too big nesting level.
* Useless checks like pointer checking after xmalloc.
* Misleading comments.
* Bad names of the variables.
As a bonus
