Re: [ovs-dev] [PATCH] netdev-offload-tc: Revert tunnel src/dst port masks handling

2020-06-18 Thread Simon Horman
On Thu, Jun 18, 2020 at 07:36:52PM +0300, Roi Dayan wrote: > > > On 2020-06-16 6:48 PM, Simon Horman wrote: > > On Tue, Jun 16, 2020 at 05:06:49PM +0300, Roi Dayan wrote: > >> > >> > >> On 2020-06-16 4:03 PM, Roi Dayan wrote: > >>> The cited commit intended to add tc support for masking tunnel sr

Re: [ovs-dev] [PATCH] netdev-offload-tc: Revert tunnel src/dst port masks handling

2020-06-18 Thread Roi Dayan
On 2020-06-16 6:48 PM, Simon Horman wrote: > On Tue, Jun 16, 2020 at 05:06:49PM +0300, Roi Dayan wrote: >> >> >> On 2020-06-16 4:03 PM, Roi Dayan wrote: >>> The cited commit intended to add tc support for masking tunnel src/dst >>> ips and ports. It's not possible to do tunnel ports masking with

Re: [ovs-dev] [PATCH] netdev-offload-tc: Revert tunnel src/dst port masks handling

2020-06-17 Thread Tonghao Zhang
On Wed, Jun 17, 2020 at 3:20 PM Roi Dayan wrote: > > > > On 2020-06-17 8:48 AM, Tonghao Zhang wrote: > > On Tue, Jun 16, 2020 at 9:05 PM Roi Dayan wrote: > >> > >> The cited commit intended to add tc support for masking tunnel src/dst > >> ips and ports. It's not possible to do tunnel ports maski

Re: [ovs-dev] [PATCH] netdev-offload-tc: Revert tunnel src/dst port masks handling

2020-06-17 Thread Roi Dayan
On 2020-06-17 8:48 AM, Tonghao Zhang wrote: > On Tue, Jun 16, 2020 at 9:05 PM Roi Dayan wrote: >> >> The cited commit intended to add tc support for masking tunnel src/dst >> ips and ports. It's not possible to do tunnel ports masking with >> openflow rules and the default mask for tunnel ports

Re: [ovs-dev] [PATCH] netdev-offload-tc: Revert tunnel src/dst port masks handling

2020-06-16 Thread Tonghao Zhang
On Tue, Jun 16, 2020 at 9:05 PM Roi Dayan wrote: > > The cited commit intended to add tc support for masking tunnel src/dst > ips and ports. It's not possible to do tunnel ports masking with > openflow rules and the default mask for tunnel ports set to 0 in > tnl_wc_init(), unlike tunnel ports def

Re: [ovs-dev] [PATCH] netdev-offload-tc: Revert tunnel src/dst port masks handling

2020-06-16 Thread Simon Horman
On Tue, Jun 16, 2020 at 05:06:49PM +0300, Roi Dayan wrote: > > > On 2020-06-16 4:03 PM, Roi Dayan wrote: > > The cited commit intended to add tc support for masking tunnel src/dst > > ips and ports. It's not possible to do tunnel ports masking with > > openflow rules and the default mask for tunn

Re: [ovs-dev] [PATCH] netdev-offload-tc: Revert tunnel src/dst port masks handling

2020-06-16 Thread Roi Dayan
On 2020-06-16 5:06 PM, Roi Dayan wrote: > > > On 2020-06-16 4:03 PM, Roi Dayan wrote: >> The cited commit intended to add tc support for masking tunnel src/dst >> ips and ports. It's not possible to do tunnel ports masking with >> openflow rules and the default mask for tunnel ports set to 0 i

Re: [ovs-dev] [PATCH] netdev-offload-tc: Revert tunnel src/dst port masks handling

2020-06-16 Thread Roi Dayan
On 2020-06-16 4:03 PM, Roi Dayan wrote: > The cited commit intended to add tc support for masking tunnel src/dst > ips and ports. It's not possible to do tunnel ports masking with > openflow rules and the default mask for tunnel ports set to 0 in > tnl_wc_init(), unlike tunnel ports default mask

[ovs-dev] [PATCH] netdev-offload-tc: Revert tunnel src/dst port masks handling

2020-06-16 Thread Roi Dayan
The cited commit intended to add tc support for masking tunnel src/dst ips and ports. It's not possible to do tunnel ports masking with openflow rules and the default mask for tunnel ports set to 0 in tnl_wc_init(), unlike tunnel ports default mask which is full mask. So instead of never passing tu