Re: [ovs-dev] [PATCH] odp-util: Avoid reading wrong table in generate_all_wildcard_mask().

2017-12-21 Thread Ben Pfaff
On Wed, Dec 20, 2017 at 03:12:43PM -0800, Justin Pettit wrote: > > > > On Nov 27, 2017, at 9:20 AM, Ben Pfaff wrote: > > > > These lines of code are intended to copy the 'next' and 'next_max' members > > of tbl[type] into local variables 'tbl' and 'max': > >tbl = tbl[type].next; > >

Re: [ovs-dev] [PATCH] odp-util: Avoid reading wrong table in generate_all_wildcard_mask().

2017-12-20 Thread Justin Pettit
> On Nov 27, 2017, at 9:20 AM, Ben Pfaff wrote: > > These lines of code are intended to copy the 'next' and 'next_max' members > of tbl[type] into local variables 'tbl' and 'max': >tbl = tbl[type].next; >max = tbl[type].next_max; > They didn't do it properly because the

[ovs-dev] [PATCH] odp-util: Avoid reading wrong table in generate_all_wildcard_mask().

2017-11-27 Thread Ben Pfaff
These lines of code are intended to copy the 'next' and 'next_max' members of tbl[type] into local variables 'tbl' and 'max': tbl = tbl[type].next; max = tbl[type].next_max; They didn't do it properly because the first line changes 'tbl', so that the first and seconds lines'