Re: [ovs-dev] [PATCH] ofp-actions: Fix memory leak on error path.

2020-04-14 Thread William Tu
On Mon, Apr 13, 2020 at 9:26 AM Yifeng Sun wrote: > > Looks good to me, thanks. > > Reviewed-by: Yifeng Sun > Applied to master, thanks ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ofp-actions: Fix memory leak on error path.

2020-04-13 Thread Yifeng Sun
Looks good to me, thanks. Reviewed-by: Yifeng Sun On Mon, Apr 13, 2020 at 8:43 AM William Tu wrote: > Need to free the memory before return. Detected by gcc10. > > Signed-off-by: William Tu > --- > lib/ofp-actions.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/ofp-actions.c

[ovs-dev] [PATCH] ofp-actions: Fix memory leak on error path.

2020-04-13 Thread William Tu
Need to free the memory before return. Detected by gcc10. Signed-off-by: William Tu --- lib/ofp-actions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index ef8b2b4527f9..a94d1a7ca918 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-actions.c @@ -5966,6

Re: [ovs-dev] [PATCH] ofp-actions: Fix memory leak.

2020-03-20 Thread William Tu
On Wed, Mar 18, 2020 at 07:48:56AM -0700, Gregory Rose wrote: > > > On 3/17/2020 4:31 PM, William Tu wrote: > >Coverity CID 279274 reports leaking previously allocated > >'error' buffer when 'return xasprintf("input too big");'. > > > >Cc: Usman Ansari > >Signed-off-by: William Tu > >--- > >

Re: [ovs-dev] [PATCH] ofp-actions: Fix memory leak.

2020-03-18 Thread Gregory Rose
On 3/17/2020 4:31 PM, William Tu wrote: Coverity CID 279274 reports leaking previously allocated 'error' buffer when 'return xasprintf("input too big");'. Cc: Usman Ansari Signed-off-by: William Tu --- lib/ofp-actions.c | 1 + 1 file changed, 1 insertion(+) diff --git

[ovs-dev] [PATCH] ofp-actions: Fix memory leak.

2020-03-17 Thread William Tu
Coverity CID 279274 reports leaking previously allocated 'error' buffer when 'return xasprintf("input too big");'. Cc: Usman Ansari Signed-off-by: William Tu --- lib/ofp-actions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index

Re: [ovs-dev] [PATCH] ofp-actions: Fix memory leak on error path in parse_CT().

2017-05-30 Thread Ben Pfaff
On Tue, May 30, 2017 at 09:44:00AM -0700, Joe Stringer wrote: > On 26 May 2017 at 16:28, Ben Pfaff wrote: > > Found by Coverity. > > > > Reported-at: > > https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762959=4305310=180392 > > Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH] ofp-actions: Fix memory leak on error path in parse_CT().

2017-05-26 Thread Ben Pfaff
Found by Coverity. Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762959=4305310=180392 Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c