Re: [ovs-dev] [PATCH] ofproto: Fix resource usage explosion while processing bundled FLOW_MOD.

2021-11-30 Thread Ilya Maximets
On 11/22/21 09:07, Vladislav Odintsov wrote: > Thanks for the patch Ilya! > > I’ve tested this with my setup in OVN similar to described in message by link > at "Reported-at". > ovs-vswitchd with this patch applied seems working fine. It processed flows > and though with high CPU load during

Re: [ovs-dev] [PATCH] ofproto: Fix resource usage explosion while processing bundled FLOW_MOD.

2021-11-23 Thread Vladislav Odintsov
I’ve re-checked and it really stopped growing after a couple of iterations. Thanks again for the patches. Regards, Vladislav Odintsov > On 23 Nov 2021, at 02:03, Ilya Maximets wrote: > > On 11/22/21 20:54, Vladislav Odintsov wrote: >> Hi Ilya, >> >> I’ve tested both patches, the problem with

Re: [ovs-dev] [PATCH] ofproto: Fix resource usage explosion while processing bundled FLOW_MOD.

2021-11-22 Thread Ilya Maximets
On 11/22/21 20:54, Vladislav Odintsov wrote: > Hi Ilya, > > I’ve tested both patches, the problem with high CPU seems to be solved, > thanks. > I noticed see that if I add/delete one lsp to/from port group with a negative > match rule, ovs-vswitchd each time (add or remove) consumes +4-18 MB

Re: [ovs-dev] [PATCH] ofproto: Fix resource usage explosion while processing bundled FLOW_MOD.

2021-11-22 Thread Vladislav Odintsov
Hi Ilya, I’ve tested both patches, the problem with high CPU seems to be solved, thanks. I noticed see that if I add/delete one lsp to/from port group with a negative match rule, ovs-vswitchd each time (add or remove) consumes +4-18 MB RSS. # ovn-nbctl pg-set-ports pg_1 lsp1 lsp2 lsp3 lsp4

Re: [ovs-dev] [PATCH] ofproto: Fix resource usage explosion while processing bundled FLOW_MOD.

2021-11-22 Thread Ilya Maximets
On 11/22/21 10:18, Vladislav Odintsov wrote: > Ilya, > > there’s a problem still in place, just with another case. > Initially I’ve tested only creation of topology, but didn’t think about > testing the modification of those flows. > > Create topology from initial mail, and then modify it

Re: [ovs-dev] [PATCH] ofproto: Fix resource usage explosion while processing bundled FLOW_MOD.

2021-11-22 Thread Vladislav Odintsov
Ilya, there’s a problem still in place, just with another case. Initially I’ve tested only creation of topology, but didn’t think about testing the modification of those flows. Create topology from initial mail, and then modify it somehow. For instance, change the LSPs in port group. Consider

Re: [ovs-dev] [PATCH] ofproto: Fix resource usage explosion while processing bundled FLOW_MOD.

2021-11-22 Thread Vladislav Odintsov
Thanks for the patch Ilya! I’ve tested this with my setup in OVN similar to described in message by link at "Reported-at". ovs-vswitchd with this patch applied seems working fine. It processed flows and though with high CPU load during ~3-5 seconds after start, it went to normal CPU load about

[ovs-dev] [PATCH] ofproto: Fix resource usage explosion while processing bundled FLOW_MOD.

2021-11-19 Thread Ilya Maximets
While processing a bundle, OVS will add all new and modified rules to classifiers. Classifiers are using RCU-protected pvector to store subtables. Addition of a new subtable or removal of the old one leads to re-allocation and memory copy of the pvector array. Old version of that array is given