Re: [ovs-dev] [PATCH] ofproto: Fix statistics of datapath operations.

2020-10-14 Thread Ilya Maximets
On 10/14/20 3:19 PM, Stokes, Ian wrote: >> If 'stats->n_packets' is less than 'op->ukey->stats.n_packets', >> the calculation result will be wrong. >> 'stats->n_bytes' is the same. >> > > Thanks for the patch, seems like a reasonable change, also I think this could > be backported as far as OVS

Re: [ovs-dev] [PATCH] ofproto: Fix statistics of datapath operations.

2020-10-14 Thread Fabrizio D'Angelo
I believe this is the commit that introduced the issue: 13bb6ed00c10ae46b3f9b92d05edb41398714166 On Wed, Oct 14, 2020 at 9:19 AM Stokes, Ian wrote: > > > If 'stats->n_packets' is less than 'op->ukey->stats.n_packets', > > the calculation result will be wrong. > > 'stats->n_bytes' is the same. >

Re: [ovs-dev] [PATCH] ofproto: Fix statistics of datapath operations.

2020-10-14 Thread Stokes, Ian
> If 'stats->n_packets' is less than 'op->ukey->stats.n_packets', > the calculation result will be wrong. > 'stats->n_bytes' is the same. > Thanks for the patch, seems like a reasonable change, also I think this could be backported as far as OVS 2.6. One thing is could do with a fixes tag to

[ovs-dev] [PATCH] ofproto: Fix statistics of datapath operations.

2020-06-02 Thread zhaozhanxu
If 'stats->n_packets' is less than 'op->ukey->stats.n_packets', the calculation result will be wrong. 'stats->n_bytes' is the same. Signed-off-by: zhaozhanxu --- ofproto/ofproto-dpif-upcall.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git