Re: [ovs-dev] [PATCH] ofproto-dpif: Increase dp_hash default max buckets

2021-10-15 Thread Eelco Chaudron
Hi Mike, See some comments below… Cheers, Eelco On 15 Oct 2021, at 4:05, Mike Pattrick wrote: > Currently when a user creates an open flow group with with multiple > buckets without specifying a selection type, the efficient dp_hash is > only selected if there are fewer than 64 buckets. But wh

[ovs-dev] [PATCH] ofproto-dpif: Increase dp_hash default max buckets

2021-10-14 Thread Mike Pattrick
Currently when a user creates an open flow group with with multiple buckets without specifying a selection type, the efficient dp_hash is only selected if there are fewer than 64 buckets. But when dp_hash is explicitly selected, up to 256 buckets are supported. While 64 buckets seems like a lot, c

Re: [ovs-dev] [PATCH] ofproto-dpif: Increase dp_hash default max buckets

2021-10-14 Thread 0-day Robot
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Mike Pattrick needs to sign off. WARNING: Unexpected sign-offs from developers

[ovs-dev] [PATCH] ofproto-dpif: Increase dp_hash default max buckets

2021-10-14 Thread Mike Pattrick
Currently when a user creates an open flow group with with multiple buckets without specifying a selection type, the efficient dp_hash is only selected if there are fewer than 64 buckets. But when dp_hash is explicitly selected, up to 256 buckets are supported. While 64 buckets seems like a lot, c