Re: [ovs-dev] [PATCH] ofproto-dpif-trace: Make -generate send packets to controller again.

2018-08-27 Thread Ben Pfaff
On Fri, Aug 24, 2018 at 01:30:24PM -0700, Justin Pettit wrote: > > > On Aug 24, 2018, at 12:25 PM, Ben Pfaff wrote: > > > > +/* Copies ODP actions from 'in' (with length 'size') to 'out', dropping > > + * OVS_ACTION_ATTR_OUTPUT along the way. */ > > +static void > > +prune_output_actions(const s

Re: [ovs-dev] [PATCH] ofproto-dpif-trace: Make -generate send packets to controller again.

2018-08-24 Thread Justin Pettit
> On Aug 24, 2018, at 12:25 PM, Ben Pfaff wrote: > > +/* Copies ODP actions from 'in' (with length 'size') to 'out', dropping > + * OVS_ACTION_ATTR_OUTPUT along the way. */ > +static void > +prune_output_actions(const struct ofpbuf *in, struct ofpbuf *out) Do you think it's worth clarifying th

[ovs-dev] [PATCH] ofproto-dpif-trace: Make -generate send packets to controller again.

2018-08-24 Thread Ben Pfaff
Prior to the OVS 2.9 development cycle, any flow that sent a packet to a controller required that the flow be slow-pathed. In some cases this led to poor performance, so OVS 2.9 made controller actions fast-pathable. As a side effect of the change, "ovs-appctl ofproto/trace -generate" no longer s