Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-07-31 Thread Ilya Maximets
On 7/31/23 18:01, Mike Pattrick wrote: > On Mon, Jul 31, 2023 at 7:20 AM Ilya Maximets wrote: >> >> On 7/31/23 07:34, Mike Pattrick wrote: >>> On Fri, Jul 28, 2023 at 6:31 PM Ilya Maximets wrote: On 7/28/23 23:13, Mike Pattrick wrote: > On Fri, Jul 28, 2023 at 7:48 AM Ilya Maximets

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-07-31 Thread Mike Pattrick
On Mon, Jul 31, 2023 at 7:20 AM Ilya Maximets wrote: > > On 7/31/23 07:34, Mike Pattrick wrote: > > On Fri, Jul 28, 2023 at 6:31 PM Ilya Maximets wrote: > >> > >> On 7/28/23 23:13, Mike Pattrick wrote: > >>> On Fri, Jul 28, 2023 at 7:48 AM Ilya Maximets >>> > wrote: >

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-07-31 Thread Ilya Maximets
On 7/31/23 07:34, Mike Pattrick wrote: > On Fri, Jul 28, 2023 at 6:31 PM Ilya Maximets wrote: >> >> On 7/28/23 23:13, Mike Pattrick wrote: >>> On Fri, Jul 28, 2023 at 7:48 AM Ilya Maximets >> > wrote: >>> >>> On 7/20/23 17:06, Mike Pattrick wrote: >>> > When the

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-07-30 Thread Mike Pattrick
On Fri, Jul 28, 2023 at 6:31 PM Ilya Maximets wrote: > > On 7/28/23 23:13, Mike Pattrick wrote: > > On Fri, Jul 28, 2023 at 7:48 AM Ilya Maximets > > wrote: > > > > On 7/20/23 17:06, Mike Pattrick wrote: > > > When the a revalidator thread is updating

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-07-28 Thread Ilya Maximets
On 7/28/23 23:13, Mike Pattrick wrote: > On Fri, Jul 28, 2023 at 7:48 AM Ilya Maximets > wrote: > > On 7/20/23 17:06, Mike Pattrick wrote: > > When the a revalidator thread is updating statistics for an XC_LEARN > > xcache entry in xlate_push_stats_entry it

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-07-28 Thread Mike Pattrick
On Fri, Jul 28, 2023 at 7:48 AM Ilya Maximets wrote: > On 7/20/23 17:06, Mike Pattrick wrote: > > When the a revalidator thread is updating statistics for an XC_LEARN > > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn. > > The revalidator will update stats for rules even

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-07-28 Thread Ilya Maximets
On 7/20/23 17:06, Mike Pattrick wrote: > When the a revalidator thread is updating statistics for an XC_LEARN > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn. > The revalidator will update stats for rules even if they are in a > removed state or marked as invisible.

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-07-21 Thread Eelco Chaudron
On 20 Jul 2023, at 17:06, Mike Pattrick wrote: > When the a revalidator thread is updating statistics for an XC_LEARN > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn. > The revalidator will update stats for rules even if they are in a > removed state or marked as

[ovs-dev] [PATCH] ofproto-dpif-xlate: Don't reinstall removed XC_LEARN rule

2023-07-20 Thread Mike Pattrick
When the a revalidator thread is updating statistics for an XC_LEARN xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn. The revalidator will update stats for rules even if they are in a removed state or marked as invisible. However, ofproto_flow_mod_learn will detect if a flow