Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix recirculation when in_port is OFPP_CONTROLLER.

2020-03-20 Thread Ben Pfaff
On Fri, Mar 20, 2020 at 02:12:55PM +0530, Numan Siddique wrote: > On Fri, Mar 20, 2020 at 6:26 AM Ben Pfaff wrote: > > > > Recirculation usually requires finding the pre-recirculation input port. > > Packets sent by the controller, with in_port of OFPP_CONTROLLER or > > OFPP_NONE, do not have a

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix recirculation when in_port is OFPP_CONTROLLER.

2020-03-20 Thread Numan Siddique
On Fri, Mar 20, 2020 at 6:26 AM Ben Pfaff wrote: > > Recirculation usually requires finding the pre-recirculation input port. > Packets sent by the controller, with in_port of OFPP_CONTROLLER or > OFPP_NONE, do not have a real input port data structure, only a port > number. The code in

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix recirculation when in_port is OFPP_CONTROLLER.

2020-03-19 Thread Ben Pfaff
Recirculation usually requires finding the pre-recirculation input port. Packets sent by the controller, with in_port of OFPP_CONTROLLER or OFPP_NONE, do not have a real input port data structure, only a port number. The code in xlate_lookup_ofproto_() mishandled this case, failing to return the