Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix segmentation fault caused by tun_table

2018-05-03 Thread Yi-Hung Wei
> If the TLV map changed, then won't replacing 'tab' by the new one cause > the packet to be misinterpreted? If so, then it would be better to > detect the change and abort translating the packet. I don't think we > currently have a way to tell whether the TLV map changed, so we'd need > to add

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix segmentation fault caused by tun_table

2018-05-03 Thread Ben Pfaff
On Tue, May 01, 2018 at 05:20:31PM -0700, Yi-Hung Wei wrote: > Currently, the revalidator thread may hit segmentation fault when geneve > TLV map is updated. It is because we may store the old TLV map (struct > tun_table) in the frozen state for recirculation, and we may access the > already