Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-03-03 Thread Mike Pattrick
On Fri, Mar 3, 2023 at 12:31 PM Adrian Moreno wrote: > > Hi Mike, > > I've gone though this patch and have some minor style comments and nits. I've > also played a bit with it and run it through valgrind and looks solid. > > On 12/8/22 17:22, Mike Pattrick wrote: > > Several xlate actions used in

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-03-03 Thread Adrian Moreno
Hi Mike, I've gone though this patch and have some minor style comments and nits. I've also played a bit with it and run it through valgrind and looks solid. On 12/8/22 17:22, Mike Pattrick wrote: Several xlate actions used in recursive translation currently store a large amount of

[ovs-dev] [PATCH] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2022-12-08 Thread Mike Pattrick
Several xlate actions used in recursive translation currently store a large amount of information on the stack. This can result in handler threads quickly running out of stack space despite before xlate_resubmit_resource_check() is able to terminate translation. This patch reduces stack usage by