Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Remove repeated function for judge garp.

2022-12-11 Thread Han Ding
-- Han Ding >On 12/1/22 07:39, Han Ding wrote: >> >> Function is_gratuitous_arp() and function is_garp() are all used to judge >> whether the flow is gratuitous arp. It is not necessary to use two functions >> to do the same thing and just keep one. > >Hi.  Thanks for the patch!

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Remove repeated function for judge garp.

2022-12-06 Thread Ilya Maximets
On 12/1/22 07:39, Han Ding wrote: > > Function is_gratuitous_arp() and function is_garp() are all used to judge > whether the flow is gratuitous arp. It is not necessary to use two functions > to do the same thing and just keep one. Hi. Thanks for the patch! These function are indeed similar,

[ovs-dev] [PATCH] ofproto-dpif-xlate: Remove repeated function for judge garp.

2022-11-30 Thread Han Ding
Function is_gratuitous_arp() and function is_garp() are all used to judge whether the flow is gratuitous arp. It is not necessary to use two functions to do the same thing and just keep one. Signed-off-by: Han Ding --- ofproto/ofproto-dpif-xlate.c | 32 ++-- 1 file