Re: [ovs-dev] [PATCH] ofproto-dpif.at: Fix broken waits in bonding tests.

2022-03-22 Thread Ilya Maximets
On 3/22/22 13:35, Ilya Maximets wrote: > On 3/21/22 17:58, Ilya Maximets wrote: >> On 3/21/22 15:45, David Marchand wrote: >>> On Mon, Mar 21, 2022 at 1:39 PM Ilya Maximets wrote: OVS_WAIT_UNTIL() macro has only 2 arguments and doesn't check the output of the command, but bonding te

Re: [ovs-dev] [PATCH] ofproto-dpif.at: Fix broken waits in bonding tests.

2022-03-22 Thread Ilya Maximets
On 3/21/22 17:58, Ilya Maximets wrote: > On 3/21/22 15:45, David Marchand wrote: >> On Mon, Mar 21, 2022 at 1:39 PM Ilya Maximets wrote: >>> >>> OVS_WAIT_UNTIL() macro has only 2 arguments and doesn't check >>> the output of the command, but bonding tests are trying to use >>> it as if it was AT_C

Re: [ovs-dev] [PATCH] ofproto-dpif.at: Fix broken waits in bonding tests.

2022-03-21 Thread Ilya Maximets
On 3/21/22 15:45, David Marchand wrote: > On Mon, Mar 21, 2022 at 1:39 PM Ilya Maximets wrote: >> >> OVS_WAIT_UNTIL() macro has only 2 arguments and doesn't check >> the output of the command, but bonding tests are trying to use >> it as if it was AT_CHECK macro. That makes checks in bonding >> t

Re: [ovs-dev] [PATCH] ofproto-dpif.at: Fix broken waits in bonding tests.

2022-03-21 Thread David Marchand
On Mon, Mar 21, 2022 at 1:39 PM Ilya Maximets wrote: > > OVS_WAIT_UNTIL() macro has only 2 arguments and doesn't check > the output of the command, but bonding tests are trying to use > it as if it was AT_CHECK macro. That makes checks in bonding > tests mostly useless, since they are not actuall

[ovs-dev] [PATCH] ofproto-dpif.at: Fix broken waits in bonding tests.

2022-03-21 Thread Ilya Maximets
OVS_WAIT_UNTIL() macro has only 2 arguments and doesn't check the output of the command, but bonding tests are trying to use it as if it was AT_CHECK macro. That makes checks in bonding tests mostly useless, since they are not actually checking anything except for command returning zero. Introduc