Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

> On Jul 27, 2017, at 7:23 PM, Han Zhou wrote: > > On Thu, Jul 27, 2017 at 5:59 PM, Justin Pettit wrote: > > > > The log action may be more generic than just for ACL. So would it better > > > to avoid hardcode "ACL" here in the message? "ACL" could be

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

> On Jul 28, 2017, at 12:38 PM, Ben Pfaff wrote: > > On Wed, Jul 26, 2017 at 01:55:14PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > checkpatch says: > >WARNING: Line has non-spaces leading whitespace >#856 FILE:

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

On Wed, Jul 26, 2017 at 01:55:14PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit checkpatch says: WARNING: Line has non-spaces leading whitespace #856 FILE: ovn/utilities/ovn-nbctl.c:1385: if (log_severity_from_string(severity) ==

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

On 28 July 2017 at 10:05, Ben Pfaff wrote: > On Thu, Jul 27, 2017 at 05:59:54PM -0700, Justin Pettit wrote: > > > > > On Jul 27, 2017, at 4:03 PM, Han Zhou wrote: > > > > > > > > > > > > On Wed, Jul 26, 2017 at 1:55 PM, Justin Pettit > wrote: >

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

On Thu, Jul 27, 2017 at 05:59:54PM -0700, Justin Pettit wrote: > > > On Jul 27, 2017, at 4:03 PM, Han Zhou wrote: > > > > > > > > On Wed, Jul 26, 2017 at 1:55 PM, Justin Pettit wrote: > > > @@ -332,7 +333,7 @@ Logical switch commands:\n\ > > >ls-list

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

On Thu, Jul 27, 2017 at 5:59 PM, Justin Pettit wrote: > > > It seems "invalid" packets won't get logged in this patch. I think it would be useful: in addition to log packets per-ACL, enable logging for packets returned as "invalid" state from conntrack. It can be a global

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

> On Jul 27, 2017, at 4:03 PM, Han Zhou wrote: > > > > On Wed, Jul 26, 2017 at 1:55 PM, Justin Pettit wrote: > > > > Signed-off-by: Justin Pettit > > --- > > NEWS| 1 + > > include/ovn/actions.h

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

On Wed, Jul 26, 2017 at 1:55 PM, Justin Pettit wrote: > > Signed-off-by: Justin Pettit > --- > NEWS| 1 + > include/ovn/actions.h | 67 --- > ovn/controller/ovn-controller.8.xml | 9 +++ >

[ovs-dev] [PATCH] ovn: Add support for ACL logging.

Signed-off-by: Justin Pettit --- NEWS| 1 + include/ovn/actions.h | 67 --- ovn/controller/ovn-controller.8.xml | 9 +++ ovn/controller/pinctrl.c| 38 +++ ovn/lib/actions.c