Looks great! but you forgot the testing for the mult option. Rather simple
anyway it's obvious it works, but it's my only nit :)
On Wed, Sep 26, 2018 at 10:30 AM Numan Siddique wrote:
>
>
> On Tue, Sep 25, 2018 at 10:18 PM Miguel Angel Ajo Pelayo <
> majop...@redhat.com> wrote:
>
>> Nak,
>>
On Tue, Sep 25, 2018 at 10:18 PM Miguel Angel Ajo Pelayo <
majop...@redhat.com> wrote:
> Nak,
>
> Great work, this will be useful to adjust parameters based on specific
> network conditions, or while debugging network issues (to reduce flapping).
>
> I miss the "mult" parameter to setup the
From: Numan Siddique
With this commit the users can override the default values of
the BFD params - min_rx, min_tx, decay_min_rx and mult if desired.
This can be useful to debug any issues related to BFD, like BFD
state changes seen frequently.
ovn-controller checks for the options
Nak,
Great work, this will be useful to adjust parameters based on specific
network conditions, or while debugging network issues (to reduce flapping).
I miss the "mult" parameter to setup the detection multiplier (rx_interval
* mult).
Thanks a lot,
Miguel Ángel.
On Tue, Sep 25, 2018 at 5:46
On Mon, Sep 24, 2018 at 3:12 PM wrote:
> From: Numan Siddique
>
> With this commit the users can override the default BFD params -
> min_rx, min_tx and decay_min_rx if desired. This can be useful
> to debug any issues related to BFD, like BFD state changes are
> seen frequently.
>
>
From: Numan Siddique
With this commit the users can override the default BFD params -
min_rx, min_tx and decay_min_rx if desired. This can be useful
to debug any issues related to BFD, like BFD state changes are
seen frequently.
ovn-controller checks for the options 'ovn-bfd-min-rx',
