Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-27 Thread Ben Pfaff
On Wed, Mar 27, 2019 at 09:10:12AM +0100, Simon Horman wrote: > On Tue, Mar 26, 2019 at 09:04:05AM -0700, Ben Pfaff wrote: > > On Tue, Mar 26, 2019 at 02:17:07PM +0100, Simon Horman wrote: > > > From my point of view travisci passing is a base requirement > > > for applying patches, in particular b

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-27 Thread solomon
Simon Horman wrote: Also need to backport commit 0b4caa2eba to branch2.6~2.10. >>> >>> Thanks, I have made preliminary backports to the relevant branches >>> and am running travisci to see if the tests pass. >>> >>> https://travis-ci.org/horms2/ovs/builds/511479533 >> >> The check above, o

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-27 Thread Simon Horman
On Wed, Mar 27, 2019 at 10:37:03AM +0100, Simon Horman wrote: > On Tue, Mar 26, 2019 at 02:17:07PM +0100, Simon Horman wrote: > > On Tue, Mar 26, 2019 at 04:50:03PM +0800, solomon wrote: > > > Ilya Maximets wrote: > > > >> On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote: > > > >>> Ben Pfaff

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-27 Thread Simon Horman
On Tue, Mar 26, 2019 at 02:17:07PM +0100, Simon Horman wrote: > On Tue, Mar 26, 2019 at 04:50:03PM +0800, solomon wrote: > > Ilya Maximets wrote: > > >> On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote: > > >>> Ben Pfaff wrote: > > On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote:

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-27 Thread Simon Horman
On Tue, Mar 26, 2019 at 09:04:05AM -0700, Ben Pfaff wrote: > On Tue, Mar 26, 2019 at 02:17:07PM +0100, Simon Horman wrote: > > From my point of view travisci passing is a base requirement > > for applying patches, in particular backports to released versions. > > I agree in principle, but I don't

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-26 Thread Ben Pfaff
On Tue, Mar 26, 2019 at 02:17:07PM +0100, Simon Horman wrote: > From my point of view travisci passing is a base requirement > for applying patches, in particular backports to released versions. I agree in principle, but I don't know how to work that in with the number of patches I apply. It woul

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-26 Thread Simon Horman
On Tue, Mar 26, 2019 at 04:50:03PM +0800, solomon wrote: > Ilya Maximets wrote: > >> On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote: > >>> Ben Pfaff wrote: > On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote: > > > > After inserting/removing a bucket, we don't update the

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-26 Thread solomon
Ilya Maximets wrote: >> On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote: >>> Ben Pfaff wrote: On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote: > > After inserting/removing a bucket, we don't update the bucket counter. > When we call ovs-ofctl dump-group-stats br-int,

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-26 Thread Ilya Maximets
> On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote: >> Ben Pfaff wrote: >> > On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote: >> >> >> >> After inserting/removing a bucket, we don't update the bucket counter. >> >> When we call ovs-ofctl dump-group-stats br-int, a panic happened. >> >

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-25 Thread solomon
Ben Pfaff wrote: > On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote: >> Ben Pfaff wrote: >>> On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote: After inserting/removing a bucket, we don't update the bucket counter. When we call ovs-ofctl dump-group-stats br-int, a panic

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-25 Thread Ben Pfaff
On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote: > Ben Pfaff wrote: > > On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote: > >> > >> After inserting/removing a bucket, we don't update the bucket counter. > >> When we call ovs-ofctl dump-group-stats br-int, a panic happened. > > > > Th

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-20 Thread solomon
Ben Pfaff wrote: > On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote: >> >> After inserting/removing a bucket, we don't update the bucket counter. >> When we call ovs-ofctl dump-group-stats br-int, a panic happened. > > Thanks for the patch! It looks correct to me. Thank you for adding a >

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-20 Thread Ben Pfaff
On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote: > > After inserting/removing a bucket, we don't update the bucket counter. > When we call ovs-ofctl dump-group-stats br-int, a panic happened. Thanks for the patch! It looks correct to me. Thank you for adding a test, too. I took a closer

[ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-20 Thread Li Wei
After inserting/removing a bucket, we don't update the bucket counter. When we call ovs-ofctl dump-group-stats br-int, a panic happened. Reproduce steps: 1. ovs-ofctl -O OpenFlow15 add-group br-int "group_id=1, type=select, selection_method=hash bucket=bucket_id=1,weight:100,actions=output:1" 2