Thanks for the patch and answering my questions earlier. Please see few
comments inline below
On Fri, Nov 16, 2018 at 11:03 PM Gregory Smith wrote:
> See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the
> server should validate that the client's requested IP matches the
> offe
On Tue, Nov 20, 2018 at 1:37 AM Gregory Smith wrote:
> Numan Siddique wrote:
> > On Fri, Nov 16, 2018 at 11:03 PM Gregory Smith
> wrote:
> >
> > > See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the
> > > server should validate that the client's requested IP matches the
> > > o
Numan Siddique wrote:
> On Fri, Nov 16, 2018 at 11:03 PM Gregory Smith wrote:
>
> > See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the
> > server should validate that the client's requested IP matches the
> > offered IP.
>
> When we added the native DHCP support in OVN, we pri
On Fri, Nov 16, 2018 at 11:03 PM Gregory Smith wrote:
> See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the
> server should validate that the client's requested IP matches the
> offered IP. If not, the server should reply with a DHCPNAK. The client's
> requested IP is either spe
See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the
server should validate that the client's requested IP matches the
offered IP. If not, the server should reply with a DHCPNAK. The client's
requested IP is either specified as the Requested IP Address (option
50), or as the ciaddr
