Re: [ovs-dev] [PATCH] python-stream: handle SSL error in do_handshake

2023-04-20 Thread Simon Horman
On Thu, Apr 20, 2023 at 05:31:23PM +0200, Stefan Hoffmann wrote: > On Thu, 2023-04-20 at 15:50 +0200, Simon Horman wrote: > > On Thu, Apr 20, 2023 at 02:18:33PM +0200, David Marchand wrote: > > > On Thu, Apr 20, 2023 at 2:06 PM Simon Horman > > > wrote: > > > > > I do see CI failures, but I think

Re: [ovs-dev] [PATCH] python-stream: handle SSL error in do_handshake

2023-04-20 Thread Stefan Hoffmann
On Thu, 2023-04-20 at 15:50 +0200, Simon Horman wrote: > On Thu, Apr 20, 2023 at 02:18:33PM +0200, David Marchand wrote: > > On Thu, Apr 20, 2023 at 2:06 PM Simon Horman > > wrote: > > > > I do see CI failures, but I think these are false negatives: > > > > > > > > * > > > > https://patchwork.o

Re: [ovs-dev] [PATCH] python-stream: handle SSL error in do_handshake

2023-04-20 Thread Simon Horman
On Thu, Apr 20, 2023 at 02:18:33PM +0200, David Marchand wrote: > On Thu, Apr 20, 2023 at 2:06 PM Simon Horman > wrote: > > > I do see CI failures, but I think these are false negatives: > > > > > > * > > > https://patchwork.ozlabs.org/project/openvswitch/patch/3f70ca7bafad296e18ed9579f30fd7044c

Re: [ovs-dev] [PATCH] python-stream: handle SSL error in do_handshake

2023-04-20 Thread David Marchand
On Thu, Apr 20, 2023 at 2:06 PM Simon Horman wrote: > > I do see CI failures, but I think these are false negatives: > > > > * > > https://patchwork.ozlabs.org/project/openvswitch/patch/3f70ca7bafad296e18ed9579f30fd7044c47fc61.ca...@cloudandheat.com/ > > > > I'm retrying the GitHub based jobs her

Re: [ovs-dev] [PATCH] python-stream: handle SSL error in do_handshake

2023-04-20 Thread Simon Horman
On Thu, Apr 20, 2023 at 01:35:59PM +0200, Simon Horman wrote: > On Thu, Apr 20, 2023 at 10:14:14AM +0200, Stefan Hoffmann wrote: > > In some cases ovsdb server or relay gets restarted, ovsdb python clients > > may keep the local socket open. Instead of reconnecting a lot of failures > > will be log

Re: [ovs-dev] [PATCH] python-stream: handle SSL error in do_handshake

2023-04-20 Thread Simon Horman
On Thu, Apr 20, 2023 at 10:14:14AM +0200, Stefan Hoffmann wrote: > In some cases ovsdb server or relay gets restarted, ovsdb python clients > may keep the local socket open. Instead of reconnecting a lot of failures > will be logged. > This can be reproduced with ssl connections to the server/relay

[ovs-dev] [PATCH] python-stream: handle SSL error in do_handshake

2023-04-20 Thread Stefan Hoffmann
In some cases ovsdb server or relay gets restarted, ovsdb python clients may keep the local socket open. Instead of reconnecting a lot of failures will be logged. This can be reproduced with ssl connections to the server/relay and restarting it, so it has the same IP after restart. This patch catc

Re: [ovs-dev] [PATCH] python-stream: handle SSL error in do_handshake

2023-04-19 Thread 0-day Robot
Bleep bloop. Greetings Stefan Hoffmann, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Co-author Luca Czesla needs to sign off. Lines checked: 81, Warnings: 0, Errors: 1

[ovs-dev] [PATCH] python-stream: handle SSL error in do_handshake

2023-04-19 Thread Stefan Hoffmann
In some cases ovsdb server or relay gets restarted, ovsdb python clients may keep the local socket open. Instead of reconnecting a lot of failures will be logged. This can be reproduced with ssl connections to the server/relay and restarting it, so it has the same IP after restart. This patch catc