Re: [ovs-dev] [PATCH] rhel: Use PIDFile on forking systemd service files

2019-04-23 Thread Candido Campos Rivas
I think that it s a good configuration change whithout risks :) On Tue, Apr 23, 2019 at 7:57 PM Guru Shetty wrote: > > > On Mon, 22 Apr 2019 at 14:02, Guru Shetty wrote: > >> >> >> On Thu, 28 Feb 2019 at 09:37, Timothy Redaelli >> wrote: >> >>> Currently, PIDFile is not used in systemd service

Re: [ovs-dev] [PATCH] rhel: Use PIDFile on forking systemd service files

2019-04-23 Thread Guru Shetty
On Mon, 22 Apr 2019 at 14:02, Guru Shetty wrote: > > > On Thu, 28 Feb 2019 at 09:37, Timothy Redaelli > wrote: > >> Currently, PIDFile is not used in systemd service files with >> Type=forking. This means sometimes systemd fails to restart a daemon >> that is killed (with SIGKILL) or that is cra

Re: [ovs-dev] [PATCH] rhel: Use PIDFile on forking systemd service files

2019-04-22 Thread Guru Shetty
On Thu, 28 Feb 2019 at 09:37, Timothy Redaelli wrote: > Currently, PIDFile is not used in systemd service files with > Type=forking. This means sometimes systemd fails to restart a daemon > that is killed (with SIGKILL) or that is crashed. > > This commit adds PIDFile to all systemd service file

Re: [ovs-dev] [PATCH] rhel: Use PIDFile on forking systemd service files

2019-02-28 Thread Ben Pfaff
On Thu, Feb 28, 2019 at 05:06:40PM -0300, Flavio Leitner wrote: > On Thu, Feb 28, 2019 at 06:27:46PM +0100, Timothy Redaelli wrote: > > Currently, PIDFile is not used in systemd service files with > > Type=forking. This means sometimes systemd fails to restart a daemon > > that is killed (with SIGK

Re: [ovs-dev] [PATCH] rhel: Use PIDFile on forking systemd service files

2019-02-28 Thread Flavio Leitner
On Thu, Feb 28, 2019 at 06:27:46PM +0100, Timothy Redaelli wrote: > Currently, PIDFile is not used in systemd service files with > Type=forking. This means sometimes systemd fails to restart a daemon > that is killed (with SIGKILL) or that is crashed. > > This commit adds PIDFile to all systemd se

Re: [ovs-dev] [PATCH] rhel: Use PIDFile on forking systemd service files

2019-02-28 Thread Candido Campos Rivas
hi, yes, if there are some expert in systemd, it'd be the best :) I only can help passing you the systemd doc cof that recommends use this option with the forking type : https://www.freedesktop.org/software/systemd/man/systemd.service.html . Type= Configures the process start-up type fo

Re: [ovs-dev] [PATCH] rhel: Use PIDFile on forking systemd service files

2019-02-28 Thread Ben Pfaff
On Thu, Feb 28, 2019 at 06:27:46PM +0100, Timothy Redaelli wrote: > Currently, PIDFile is not used in systemd service files with > Type=forking. This means sometimes systemd fails to restart a daemon > that is killed (with SIGKILL) or that is crashed. > > This commit adds PIDFile to all systemd se

[ovs-dev] [PATCH] rhel: Use PIDFile on forking systemd service files

2019-02-28 Thread Timothy Redaelli
Currently, PIDFile is not used in systemd service files with Type=forking. This means sometimes systemd fails to restart a daemon that is killed (with SIGKILL) or that is crashed. This commit adds PIDFile to all systemd service file with Type=forking in order to always have the correct PID to moni