Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-28 Thread Roi Dayan
On 2019-10-28 10:15 AM, Simon Horman wrote: > On Fri, Oct 25, 2019 at 12:19:22PM +0200, Simon Horman wrote: >> On Thu, Oct 24, 2019 at 10:43:00AM +0200, Simon Horman wrote: >>> On Mon, Oct 21, 2019 at 07:01:38AM +, Roi Dayan wrote: On 2019-10-18 1:00 PM, Simon Horman wrote:

Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-28 Thread Simon Horman
On Fri, Oct 25, 2019 at 12:19:22PM +0200, Simon Horman wrote: > On Thu, Oct 24, 2019 at 10:43:00AM +0200, Simon Horman wrote: > > On Mon, Oct 21, 2019 at 07:01:38AM +, Roi Dayan wrote: > > > > > > > > > On 2019-10-18 1:00 PM, Simon Horman wrote: > > > > On Wed, Oct 16, 2019 at 11:53:52AM

Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-25 Thread Simon Horman
On Thu, Oct 24, 2019 at 10:43:00AM +0200, Simon Horman wrote: > On Mon, Oct 21, 2019 at 07:01:38AM +, Roi Dayan wrote: > > > > > > On 2019-10-18 1:00 PM, Simon Horman wrote: > > > On Wed, Oct 16, 2019 at 11:53:52AM +, Roi Dayan wrote: > > >> > > >> > > >> On 2019-10-16 2:40 PM, Simon

Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-24 Thread Simon Horman
On Mon, Oct 21, 2019 at 07:01:38AM +, Roi Dayan wrote: > > > On 2019-10-18 1:00 PM, Simon Horman wrote: > > On Wed, Oct 16, 2019 at 11:53:52AM +, Roi Dayan wrote: > >> > >> > >> On 2019-10-16 2:40 PM, Simon Horman wrote: > >>> On Wed, Oct 16, 2019 at 11:37:14AM +0300, Roi Dayan wrote: >

Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-21 Thread Roi Dayan
On 2019-10-18 1:00 PM, Simon Horman wrote: > On Wed, Oct 16, 2019 at 11:53:52AM +, Roi Dayan wrote: >> >> >> On 2019-10-16 2:40 PM, Simon Horman wrote: >>> On Wed, Oct 16, 2019 at 11:37:14AM +0300, Roi Dayan wrote: From: Chris Mi Currently, ovs supports to offload max

Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-18 Thread Simon Horman
On Wed, Oct 16, 2019 at 11:53:52AM +, Roi Dayan wrote: > > > On 2019-10-16 2:40 PM, Simon Horman wrote: > > On Wed, Oct 16, 2019 at 11:37:14AM +0300, Roi Dayan wrote: > >> From: Chris Mi > >> > >> Currently, ovs supports to offload max TCA_ACT_MAX_PRIO(32) actions. > >> But net sched api

Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-16 Thread Roi Dayan
On 2019-10-16 2:40 PM, Simon Horman wrote: > On Wed, Oct 16, 2019 at 11:37:14AM +0300, Roi Dayan wrote: >> From: Chris Mi >> >> Currently, ovs supports to offload max TCA_ACT_MAX_PRIO(32) actions. >> But net sched api has a limit of 4K message size which is not enough >> for 32 actions when

Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-16 Thread Simon Horman
On Wed, Oct 16, 2019 at 11:37:14AM +0300, Roi Dayan wrote: > From: Chris Mi > > Currently, ovs supports to offload max TCA_ACT_MAX_PRIO(32) actions. > But net sched api has a limit of 4K message size which is not enough > for 32 actions when echo flag is set. > > After a lot of testing, we find

Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-16 Thread 0-day Robot
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 87 characters long (recommended limit is 79) #57 FILE: lib/tc.c:1481:

[ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-16 Thread Roi Dayan
From: Chris Mi Currently, ovs supports to offload max TCA_ACT_MAX_PRIO(32) actions. But net sched api has a limit of 4K message size which is not enough for 32 actions when echo flag is set. After a lot of testing, we find that 16 actions is a reasonable number. So in this commit, we introduced