Re: [ovs-dev] [PATCH] tests/mfex: Don't require python cryptography.

2023-08-30 Thread Ilya Maximets
On 8/30/23 10:23, Eelco Chaudron wrote: > > > On 30 Aug 2023, at 10:16, David Marchand wrote: > >> Tests using mfex_fuzzy.py will fail on systems lacking the Python >> cryptography library. >> cryptography is not required, it is only imported in mfex_fuzzy.py to >> silence some warnings when

Re: [ovs-dev] [PATCH] tests/mfex: Don't require python cryptography.

2023-08-30 Thread Robin Jarry
Eelco Chaudron, Aug 30, 2023 at 11:21: > > This is very unlikely that any code will trigger a UserWarning with that > > text content. > > Well you never know ;) I would prefer the original one, as it’s more strict. Fair enough :) ___ dev mailing list

Re: [ovs-dev] [PATCH] tests/mfex: Don't require python cryptography.

2023-08-30 Thread Eelco Chaudron
On 30 Aug 2023, at 11:13, Robin Jarry wrote: > David Marchand, Aug 30, 2023 at 11:11: >>> warnings.filterwarnings("ignore", r"(blowfish|cast5)", UserWarning) >> >> It means waiving more warnings than before, but I don't think it >> really matters for this script. >> No strong opinion against

Re: [ovs-dev] [PATCH] tests/mfex: Don't require python cryptography.

2023-08-30 Thread Robin Jarry
David Marchand, Aug 30, 2023 at 11:11: > > warnings.filterwarnings("ignore", r"(blowfish|cast5)", UserWarning) > > It means waiving more warnings than before, but I don't think it > really matters for this script. > No strong opinion against your proposal. This is very unlikely that any code will

Re: [ovs-dev] [PATCH] tests/mfex: Don't require python cryptography.

2023-08-30 Thread David Marchand
On Wed, Aug 30, 2023 at 11:03 AM Robin Jarry wrote: > > David Marchand, Aug 30, 2023 at 10:16: > > Tests using mfex_fuzzy.py will fail on systems lacking the Python > > cryptography library. > > cryptography is not required, it is only imported in mfex_fuzzy.py to > > silence some warnings when

Re: [ovs-dev] [PATCH] tests/mfex: Don't require python cryptography.

2023-08-30 Thread Robin Jarry
David Marchand, Aug 30, 2023 at 10:16: > Tests using mfex_fuzzy.py will fail on systems lacking the Python > cryptography library. > cryptography is not required, it is only imported in mfex_fuzzy.py to > silence some warnings when scapy tries to load some libraries. > > Fixes: c3ed0bf34b8a

Re: [ovs-dev] [PATCH] tests/mfex: Don't require python cryptography.

2023-08-30 Thread Eelco Chaudron
On 30 Aug 2023, at 10:16, David Marchand wrote: > Tests using mfex_fuzzy.py will fail on systems lacking the Python > cryptography library. > cryptography is not required, it is only imported in mfex_fuzzy.py to > silence some warnings when scapy tries to load some libraries. > > Fixes:

[ovs-dev] [PATCH] tests/mfex: Don't require python cryptography.

2023-08-30 Thread David Marchand
Tests using mfex_fuzzy.py will fail on systems lacking the Python cryptography library. cryptography is not required, it is only imported in mfex_fuzzy.py to silence some warnings when scapy tries to load some libraries. Fixes: c3ed0bf34b8a ("tests/mfex: Silence Blowfish/CAST5 deprecation