Re: [ovs-dev] [PATCH] utilities: don't use a bashism to check that datapath exists

2018-08-03 Thread Ben Pfaff
Thanks everyone, applied to master and branch-2.10. On Wed, Aug 01, 2018 at 02:28:03PM -0700, Martin Xu wrote: > Thanks for fixing this. > > Martin > > On Wed, Aug 1, 2018 at 8:48 AM, Timothy Redaelli > wrote: > > > [[ ]] syntax is not supported, at least, by dash that Debian, Ubuntu and > > o

Re: [ovs-dev] [PATCH] utilities: don't use a bashism to check that datapath exists

2018-08-03 Thread Aaron Conole
Timothy Redaelli writes: > [[ ]] syntax is not supported, at least, by dash that Debian, Ubuntu and other > linux distributions may use instead of bash. > > This commit uses, instead, a POSIX way that is compatible with any POSIX > shell (bash, dash, busybox sh, etc). > > CC: Martin Xu > Fixes:

Re: [ovs-dev] [PATCH] utilities: don't use a bashism to check that datapath exists

2018-08-01 Thread Martin Xu
Thanks for fixing this. Martin On Wed, Aug 1, 2018 at 8:48 AM, Timothy Redaelli wrote: > [[ ]] syntax is not supported, at least, by dash that Debian, Ubuntu and > other > linux distributions may use instead of bash. > > This commit uses, instead, a POSIX way that is compatible with any POSIX >

[ovs-dev] [PATCH] utilities: don't use a bashism to check that datapath exists

2018-08-01 Thread Timothy Redaelli
[[ ]] syntax is not supported, at least, by dash that Debian, Ubuntu and other linux distributions may use instead of bash. This commit uses, instead, a POSIX way that is compatible with any POSIX shell (bash, dash, busybox sh, etc). CC: Martin Xu Fixes: 9763d17fbd05 ("utilities: check datapath