Hi Mark,
Thanks for the review (and pointers), I very much appreciate it.
I've only skimmed through it so far, but I'll take it into account when
sending v2. As I mentioned before I want to put some testing in place
first and haven't had time to get that into place yet, hopefully this
coming
Hi Tiago,
I've given patches 1 and 2 a review. I did not have any comments to add
for patch 3. I did not add any comments for items that you already had
XXX lines for, since you already understand what is missing.
Looking forward to the next patchset!
Mark
On 12/22/2017 01:53 PM, Tiago Lam w
On 1/9/18, 12:44 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell
Ball" wrote:
On 1/9/18, 11:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Mark
Michelson"
wrote:
On 12/22/2017 01:53 PM, Tiago Lam wrote:
> This patch
Hi Tiago,
Apologies if my message came across as dismissive or offensive (and to
you as well, Darrell). I realize after re-reading it that I could have
stated my intentions better. I never intended to discourage you in what
you are contributing.
Thanks for the mailing list link. I had missed
Hi Mark,
Your email strikes me as if you haven't read the previous email exchange at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-November/341089.html
(TL;DR I've asked similar questions there)
Having said that, and knowing this is happening, my intention is exactly
th
On 1/9/18, 11:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Mark
Michelson"
wrote:
On 12/22/2017 01:53 PM, Tiago Lam wrote:
> This patch-set is an initial approach at implementing the new SIP Alg,
> mentioned by Aaron at [1].
>
> I'm mostly interested in getting to
On 12/22/2017 01:53 PM, Tiago Lam wrote:
This patch-set is an initial approach at implementing the new SIP Alg,
mentioned by Aaron at [1].
I'm mostly interested in getting to know your thoughts of how this is
headed. There are a couple of points that are worth bringing up:
- As mentioned in patc
Hi Darrell,
Thanks for your initial review.
I'll work on incorporating your comments into v2 (which I'm planning to
submit already with some tests). A couple of small comments are in-line.
On 01/05/2018 06:40 AM, Darrell Ball wrote:
Thanks for the series/work; I’ll be reviewing this series,
Thanks for the series/work; I’ll be reviewing this series, but focusing on the
high level aspects initially.
Some high level comments:
I noticed that your own comments in the series often pointed out various issues
with this series, such as
assuming TCP transport, which is ‘unusual’, no NAT su
Tiago Lam writes:
> This patch-set is an initial approach at implementing the new SIP Alg,
> mentioned by Aaron at [1].
Thanks for this work, Tiago!
> I'm mostly interested in getting to know your thoughts of how this is
> headed. There are a couple of points that are worth bringing up:
> - As
This patch-set is an initial approach at implementing the new SIP Alg,
mentioned by Aaron at [1].
I'm mostly interested in getting to know your thoughts of how this is
headed. There are a couple of points that are worth bringing up:
- As mentioned in patches 1/3 and 2/3, this is still a preliminar
11 matches
Mail list logo