Re: [ovs-dev] [PATCH 0/3] ovn-northd IPAM fixes

2018-06-18 Thread Ben Pfaff
On Mon, Jun 18, 2018 at 09:06:22AM -0400, Mark Michelson wrote: > Hi Ben, > > The first two patches in this series aren't necessary. ovn_datapaths are > allocated from scratch and then all destroyed during each loop of > ovn-northd. They never survive multiple loops. When entering > init_ipam_info

Re: [ovs-dev] [PATCH 0/3] ovn-northd IPAM fixes

2018-06-18 Thread Mark Michelson
Hi Ben, The first two patches in this series aren't necessary. ovn_datapaths are allocated from scratch and then all destroyed during each loop of ovn-northd. They never survive multiple loops. When entering init_ipam_info_for_datapath(), you can assert that od->ipam_info == NULL [1]. For p

[ovs-dev] [PATCH 0/3] ovn-northd IPAM fixes

2018-06-15 Thread Ben Pfaff
While reviewing https://patchwork.ozlabs.org/patch/924319/, I discovered some bugs in IPAM that seem worth fixing. The first two patches below are minimal so that they can be backported. The third is an improvement that doesn't need backporting. Ben Pfaff (3): ovn-northd: Fix memory leak when