Re: [ovs-dev] [PATCH 01/11] ovn-nbctl: Don't die in pg_by_name_or_uuid().

2018-07-17 Thread Mark Michelson
Looks good! Acked-by: Mark Michelson On 07/17/2018 09:36 AM, Jakub Sitnicki wrote: (Cover-letter awaits moderator approval. Reposting here.) This is a continuation of an earlier series that aims to replace calls to ctl_fatal() in command handlers in ovn-nbctl. The motivation is to handle

Re: [ovs-dev] [PATCH 01/11] ovn-nbctl: Don't die in pg_by_name_or_uuid().

2018-07-17 Thread Jakub Sitnicki
(Cover-letter awaits moderator approval. Reposting here.) This is a continuation of an earlier series that aims to replace calls to ctl_fatal() in command handlers in ovn-nbctl. The motivation is to handle errors gracefully when running commands in daemon mode because as a long-lived process we

[ovs-dev] [PATCH 01/11] ovn-nbctl: Don't die in pg_by_name_or_uuid().

2018-07-17 Thread Jakub Sitnicki
Let the caller handle the error. This prepares us for reporting errors in daemon mode. Also, extend the tests to cover this error path. Signed-off-by: Jakub Sitnicki --- ovn/utilities/ovn-nbctl.c | 23 --- tests/ovn-nbctl.at| 5 + 2 files changed, 21