Re: [ovs-dev] [PATCH 01/11] socket-util: Fix error in comment on ss_format_address().

2018-04-17 Thread Ben Pfaff
On Mon, Apr 16, 2018 at 04:40:11PM -0500, Mark Michelson wrote: > Love the patchset! I found a few minor issues in some of the comments but > didn't see problems in the implementation. Note that I didn't review patch 9 > because of unfamiliarity with the area. > > Aside from the nits and patch 9:

Re: [ovs-dev] [PATCH 01/11] socket-util: Fix error in comment on ss_format_address().

2018-04-16 Thread Mark Michelson
Love the patchset! I found a few minor issues in some of the comments but didn't see problems in the implementation. Note that I didn't review patch 9 because of unfamiliarity with the area. Aside from the nits and patch 9: Acked-by: Mark Michelson On 04/13/2018 12:26

[ovs-dev] [PATCH 01/11] socket-util: Fix error in comment on ss_format_address().

2018-04-13 Thread Ben Pfaff
The output for this function is a dynamic string and doesn't have a fixed buffer size, so the comment was wrong. Signed-off-by: Ben Pfaff --- lib/socket-util.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/socket-util.c b/lib/socket-util.c index