Re: [ovs-dev] [PATCH 05/27] ovn-sbctl, ovn-nbctl, ovs-vsctl: Remove useless record id methods.

2017-05-03 Thread Ben Pfaff
On Tue, May 02, 2017 at 04:34:44PM -0400, Russell Bryant wrote: > On Tue, May 2, 2017 at 4:30 PM, Russell Bryant wrote: > > On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff wrote: > >> These only did anything if both the first two members of the struct were > >> nonnull,

Re: [ovs-dev] [PATCH 05/27] ovn-sbctl, ovn-nbctl, ovs-vsctl: Remove useless record id methods.

2017-05-02 Thread Russell Bryant
On Tue, May 2, 2017 at 4:30 PM, Russell Bryant wrote: > On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff wrote: >> These only did anything if both the first two members of the struct were >> nonnull, as you can see from the first test in get_row_by_id() in >>

[ovs-dev] [PATCH 05/27] ovn-sbctl, ovn-nbctl, ovs-vsctl: Remove useless record id methods.

2017-04-30 Thread Ben Pfaff
These only did anything if both the first two members of the struct were nonnull, as you can see from the first test in get_row_by_id() in lib/db-ctl-base.c, so these never did anything useful and I can't figure out why they're there. Signed-off-by: Ben Pfaff ---