Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-24 Thread Simon Horman
On Tue, Apr 23, 2024 at 11:33:15AM +0100, Simon Horman wrote: > On Wed, Apr 17, 2024 at 10:43:11AM +0300, Roi Dayan wrote: > > > > > > On 16/04/2024 18:48, Simon Horman wrote: > > > On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote: > > >> VLOG_WARN_BUF() is allocating memory for

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-23 Thread Simon Horman
On Wed, Apr 17, 2024 at 10:43:11AM +0300, Roi Dayan wrote: > > > On 16/04/2024 18:48, Simon Horman wrote: > > On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote: > >> VLOG_WARN_BUF() is allocating memory for the error string and should > >> e used if the configuration cannot contin

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-17 Thread Roi Dayan via dev
On 16/04/2024 18:48, Simon Horman wrote: > On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote: >> VLOG_WARN_BUF() is allocating memory for the error string and should >> e used if the configuration cannot continue and error is being returned >> so the caller has indication of rele

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-16 Thread Simon Horman
On Tue, Apr 16, 2024 at 04:21:48PM +0300, Roi Dayan via dev wrote: > VLOG_WARN_BUF() is allocating memory for the error string and should > e used if the configuration cannot continue and error is being returned > so the caller has indication of releasing the pointer. > Change to VLOG_WARN() to kee

[ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address.

2024-04-16 Thread Roi Dayan via dev
VLOG_WARN_BUF() is allocating memory for the error string and should e used if the configuration cannot continue and error is being returned so the caller has indication of releasing the pointer. Change to VLOG_WARN() to keep the logic that error is not being returned. Fixes: f4336f504b17 ("netdev