Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-03 Thread Roi Dayan via dev
On 03/10/2023 15:22, Ilya Maximets wrote: > On 10/3/23 10:33, Roi Dayan wrote: >> The cited commit fixed missing mirror packets by reset mirror when >> packets are modified but setting geneve options was also treated as >> a modified packet but should be treated as a part of set_tunnel >> which d

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-03 Thread Ilya Maximets
On 10/3/23 10:33, Roi Dayan wrote: > The cited commit fixed missing mirror packets by reset mirror when > packets are modified but setting geneve options was also treated as > a modified packet but should be treated as a part of set_tunnel > which doesn't reset mirror. > > Fixes: 1437f51fea92 ("of

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-03 Thread Simon Horman
On Tue, Oct 03, 2023 at 01:51:34PM +0300, Roi Dayan wrote: > > On 03/10/2023 13:36, Simon Horman wrote: > > On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote: > >> The cited commit fixed missing mirror packets by reset mirror when > >> packets are modified but setting geneve option

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-03 Thread Roi Dayan via dev
On 03/10/2023 13:36, Simon Horman wrote: > On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote: >> The cited commit fixed missing mirror packets by reset mirror when >> packets are modified but setting geneve options was also treated as >> a modified packet but should be treated as

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-03 Thread Simon Horman
On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote: > The cited commit fixed missing mirror packets by reset mirror when > packets are modified but setting geneve options was also treated as > a modified packet but should be treated as a part of set_tunnel > which doesn't reset mirro

[ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-03 Thread Roi Dayan via dev
The cited commit fixed missing mirror packets by reset mirror when packets are modified but setting geneve options was also treated as a modified packet but should be treated as a part of set_tunnel which doesn't reset mirror. Fixes: 1437f51fea92 ("ofproto-dpif-upcall: Mirror packets that are modi