Re: [ovs-dev] [PATCH 1/2] dpif: Don't pass in '*meter_id' to meter_set commands.

2018-08-16 Thread Justin Pettit
> On Aug 14, 2018, at 1:55 PM, Ben Pfaff wrote: > > On Wed, Aug 08, 2018 at 05:35:21PM -0700, Justin Pettit wrote: >> The original intent of the API appears to be that the underlying DPIF >> implementaion would choose a local meter id. However, neither of the >> existing datapath meter impleme

Re: [ovs-dev] [PATCH 1/2] dpif: Don't pass in '*meter_id' to meter_set commands.

2018-08-14 Thread Ben Pfaff
On Wed, Aug 08, 2018 at 05:35:21PM -0700, Justin Pettit wrote: > The original intent of the API appears to be that the underlying DPIF > implementaion would choose a local meter id. However, neither of the > existing datapath meter implementations (userspace or Linux) implemented > that; they expe

Re: [ovs-dev] [PATCH 1/2] dpif: Don't pass in '*meter_id' to meter_set commands.

2018-08-14 Thread Ben Pfaff
On Wed, Aug 08, 2018 at 05:35:21PM -0700, Justin Pettit wrote: > The original intent of the API appears to be that the underlying DPIF > implementaion would choose a local meter id. However, neither of the > existing datapath meter implementations (userspace or Linux) implemented > that; they expe

[ovs-dev] [PATCH 1/2] dpif: Don't pass in '*meter_id' to meter_set commands.

2018-08-08 Thread Justin Pettit
The original intent of the API appears to be that the underlying DPIF implementaion would choose a local meter id. However, neither of the existing datapath meter implementations (userspace or Linux) implemented that; they expected a valid meter id to be passed in, otherwise they returned an error