[ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

2017-08-06 Thread Roi Dayan
From: Paul Blakey Always implement get_ifindex without checking if offload is enabled or not as this should not be related. From ovs-dpctl we cannot tell if offload is enabled or not as other_config is not being read. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-vport.c |

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

2017-08-07 Thread Ben Pfaff
On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: > From: Paul Blakey > > Always implement get_ifindex without checking if offload is > enabled or not as this should not be related. From ovs-dpctl > we cannot tell if offload is enabled or not as other_config is > not being read. > > Sig

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

2017-08-07 Thread Ben Pfaff
On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: > On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: > > From: Paul Blakey > > > > Always implement get_ifindex without checking if offload is > > enabled or not as this should not be related. From ovs-dpctl > > we cannot tell if

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

2017-08-07 Thread Roi Dayan
On 07/08/2017 20:05, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: From: Paul Blakey Always implement get_ifindex without checking if offload is enabled or not as this should not be related. From ovs-dp

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

2017-08-08 Thread Simon Horman
On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote: > > > On 07/08/2017 20:05, Ben Pfaff wrote: > >On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: > >>On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: > >>>From: Paul Blakey > >>> > >>>Always implement get_ifindex witho

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

2017-08-08 Thread Roi Dayan
On 08/08/2017 11:04, Simon Horman wrote: On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote: On 07/08/2017 20:05, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: From: Paul Blakey Always implem

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

2017-08-08 Thread Simon Horman
On Tue, Aug 08, 2017 at 01:35:41PM +0300, Roi Dayan wrote: > > > On 08/08/2017 11:04, Simon Horman wrote: > >On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote: > >> > >> > >>On 07/08/2017 20:05, Ben Pfaff wrote: > >>>On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: > On Mon,