[ovs-dev] [PATCH 1/2] odp-util: Fix a bug in parse_odp_push_nsh_action

2018-12-26 Thread Yifeng Sun
In this piece of code, 'struct ofpbuf b' should always point to metadata so that metadata can be filled with values through ofpbuf operations, like ofpbuf_put_hex and ofpbuf_push_zeros. However, ofpbuf_push_zeros may change the data pointer of 'struct ofpbuf b' and therefore, metadata will not cont

Re: [ovs-dev] [PATCH 1/2] odp-util: Fix a bug in parse_odp_push_nsh_action

2018-12-27 Thread Ben Pfaff
On Wed, Dec 26, 2018 at 04:52:22PM -0800, Yifeng Sun wrote: > In this piece of code, 'struct ofpbuf b' should always point to > metadata so that metadata can be filled with values through ofpbuf > operations, like ofpbuf_put_hex and ofpbuf_push_zeros. However, > ofpbuf_push_zeros may change the dat

Re: [ovs-dev] [PATCH 1/2] odp-util: Fix a bug in parse_odp_push_nsh_action

2018-12-27 Thread Yifeng Sun
My apologies, let me dig this issue out. Thank you for the review! Yifeng On Thu, Dec 27, 2018 at 10:55 AM Ben Pfaff wrote: > On Wed, Dec 26, 2018 at 04:52:22PM -0800, Yifeng Sun wrote: > > In this piece of code, 'struct ofpbuf b' should always point to > > metadata so that metadata can be fill

Re: [ovs-dev] [PATCH 1/2] odp-util: Fix a bug in parse_odp_push_nsh_action

2018-12-28 Thread Jan Scheurich
Yifeng Sun ; Jan Scheurich > > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 1/2] odp-util: Fix a bug in > parse_odp_push_nsh_action > > On Wed, Dec 26, 2018 at 04:52:22PM -0800, Yifeng Sun wrote: > > In this piece of code, 'struct ofpbuf b' should always p