Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

2017-08-07 Thread Joe Stringer
On 3 August 2017 at 14:34, Ben Pfaff wrote: > On Mon, Jul 31, 2017 at 04:54:21PM -0700, Joe Stringer wrote: >> This calls is operating on messages generated by the datapath. If a >> datapath implementation sends improperly formatted netlink attributes, >> then it's possible for a revalidator threa

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

2017-08-07 Thread Joe Stringer
On 2 August 2017 at 17:11, Greg Rose wrote: > On 07/31/2017 04:54 PM, Joe Stringer wrote: >> >> This calls is operating on messages generated by the datapath. If a > > > s/calls/call > >> datapath implementation sends improperly formatted netlink attributes, >> then it's possible for a revalidator

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

2017-08-03 Thread Ben Pfaff
On Mon, Jul 31, 2017 at 04:54:21PM -0700, Joe Stringer wrote: > This calls is operating on messages generated by the datapath. If a > datapath implementation sends improperly formatted netlink attributes, > then it's possible for a revalidator thread to end up trapped in an > infinite loop iteratin

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

2017-08-02 Thread Greg Rose
On 07/31/2017 04:54 PM, Joe Stringer wrote: This calls is operating on messages generated by the datapath. If a s/calls/call datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating acros

[ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

2017-07-31 Thread Joe Stringer
This calls is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across the actions attributes. Rather than using the UNSAFE variatio