Re: [ovs-dev] [PATCH 1/3] csum: Fix csum_continue() on big endian with an odd number of bytes.

2016-12-09 Thread Daniele Di Proietto
On 09/12/2016 11:04, "Jarno Rajahalme" wrote: >Acked-by: Jarno Rajahalme Thanks Jarno, I pushed this to master and up to branch-2.3 > >> On Dec 8, 2016, at 6:50 PM, Daniele Di Proietto >> wrote: >> >> Even though it reads 16 bits at a time, csum_continue() is almost >> neutral to endia

Re: [ovs-dev] [PATCH 1/3] csum: Fix csum_continue() on big endian with an odd number of bytes.

2016-12-09 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Dec 8, 2016, at 6:50 PM, Daniele Di Proietto > wrote: > > Even though it reads 16 bits at a time, csum_continue() is almost > neutral to endianness (see RFC 1071 1.2 (B), "Byte Order Independence"). > > Consider a buffer like the following: > > : XX YY

[ovs-dev] [PATCH 1/3] csum: Fix csum_continue() on big endian with an odd number of bytes.

2016-12-08 Thread Daniele Di Proietto
Even though it reads 16 bits at a time, csum_continue() is almost neutral to endianness (see RFC 1071 1.2 (B), "Byte Order Independence"). Consider a buffer like the following: : XX YY XX YY XX YY XX YY ZZ Each couple of bytes is interpreted on little endian as: *data = 0xYYXX while on