Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: Fix double attaching of virtual devices.

2017-05-12 Thread Ilya Maximets
Hi. Sorry for late response. Comments inline. Best regards, Ilya Maximets. On 22.04.2017 05:01, Ben Pfaff wrote: > On Mon, Apr 03, 2017 at 06:04:16PM +0300, Ilya Maximets wrote: >> 'devargs' for virtual devices contains not only name but >> also a list of arguments like this: >> >>

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: Fix double attaching of virtual devices.

2017-04-21 Thread Ben Pfaff
On Mon, Apr 03, 2017 at 06:04:16PM +0300, Ilya Maximets wrote: > 'devargs' for virtual devices contains not only name but > also a list of arguments like this: > > 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' > or > 'eth_af_packet0,iface=eth0' > > We must cut off the

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: Fix double attaching of virtual devices.

2017-04-03 Thread Aaron Conole
Ilya Maximets writes: > 'devargs' for virtual devices contains not only name but > also a list of arguments like this: > > 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' > or > 'eth_af_packet0,iface=eth0' > > We must cut off the arguments from

[ovs-dev] [PATCH 1/3] netdev-dpdk: Fix double attaching of virtual devices.

2017-04-03 Thread Ilya Maximets
'devargs' for virtual devices contains not only name but also a list of arguments like this: 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' or 'eth_af_packet0,iface=eth0' We must cut off the arguments from this string before calling 'rte_eth_dev_get_port_by_name()'