Re: [ovs-dev] [PATCH 2/2] Subject: [PATCH] netdev-linux.c: unreachable code

2020-04-01 Thread Simon Horman
On Tue, Mar 31, 2020 at 08:15:25AM -0700, Usman S. Ansari wrote: > On Tue, Mar 31, 2020 at 7:00 AM Simon Horman > wrote: > > > On Mon, Mar 30, 2020 at 12:36:51PM -0700, Ben Pfaff wrote: > > > On Mon, Mar 30, 2020 at 12:15:46PM -0700, ua1...@gmail.com wrote: > > > > From: Usman Ansari > > > > > >

Re: [ovs-dev] [PATCH 2/2] Subject: [PATCH] netdev-linux.c: unreachable code

2020-03-31 Thread Usman S. Ansari
On Tue, Mar 31, 2020 at 7:00 AM Simon Horman wrote: > On Mon, Mar 30, 2020 at 12:36:51PM -0700, Ben Pfaff wrote: > > On Mon, Mar 30, 2020 at 12:15:46PM -0700, ua1...@gmail.com wrote: > > > From: Usman Ansari > > > > > > Coverity reports unreachable code in "?" statement > > > Fixed by removing c

Re: [ovs-dev] [PATCH 2/2] Subject: [PATCH] netdev-linux.c: unreachable code

2020-03-31 Thread Simon Horman
On Mon, Mar 30, 2020 at 12:36:51PM -0700, Ben Pfaff wrote: > On Mon, Mar 30, 2020 at 12:15:46PM -0700, ua1...@gmail.com wrote: > > From: Usman Ansari > > > > Coverity reports unreachable code in "?" statement > > Fixed by removing code segment > > > > Signed-off-by: Usman Ansari > > This code

Re: [ovs-dev] [PATCH 2/2] Subject: [PATCH] netdev-linux.c: unreachable code

2020-03-30 Thread Ben Pfaff
On Mon, Mar 30, 2020 at 12:15:46PM -0700, ua1...@gmail.com wrote: > From: Usman Ansari > > Coverity reports unreachable code in "?" statement > Fixed by removing code segment > > Signed-off-by: Usman Ansari This code looks pretty confused. I don't think we should just change it without unders

[ovs-dev] [PATCH 2/2] Subject: [PATCH] netdev-linux.c: unreachable code

2020-03-30 Thread ua1422
From: Usman Ansari Coverity reports unreachable code in "?" statement Fixed by removing code segment Signed-off-by: Usman Ansari --- lib/netdev-linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index c6e46f1..8ee047b 100644