Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Drop invalid parsed packets

2024-05-06 Thread Roi Dayan via dev
On 06/05/2024 14:05, Ilya Maximets wrote: > On 5/5/24 08:42, Roi Dayan via dev wrote: >> From: Eli Britstein >> >> In case of a malformed packet, its parsing fails. Instead of continuing >> and possible form a wrong flow, drop the packet. > > Hi, Eli and Roi. Thanks for the patch! > > But I

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Drop invalid parsed packets

2024-05-06 Thread Ilya Maximets
On 5/5/24 08:42, Roi Dayan via dev wrote: > From: Eli Britstein > > In case of a malformed packet, its parsing fails. Instead of continuing > and possible form a wrong flow, drop the packet. Hi, Eli and Roi. Thanks for the patch! But I don't think we can do that. There are few reasons why the

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Drop invalid parsed packets

2024-05-05 Thread 0-day Robot
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: dpif-netdev: Drop invalid parsed packe

[ovs-dev] [PATCH 2/2] dpif-netdev: Drop invalid parsed packets

2024-05-04 Thread Roi Dayan via dev
From: Eli Britstein In case of a malformed packet, its parsing fails. Instead of continuing and possible form a wrong flow, drop the packet. Relevant tests changed to send valid packets. Signed-off-by: Eli Britstein Acked-by: Roi Dayan --- lib/dpif-netdev.c| 7 ++- tests/mpls-xla