Re: [ovs-dev] [PATCH 2/2] ofproto: Clean up style in ofproto_flow_mod_learn.

2017-03-20 Thread Joe Stringer
On 17 March 2017 at 16:06, Ben Pfaff wrote: > On Fri, Mar 17, 2017 at 11:38:35AM -0700, Joe Stringer wrote: >> It's slightly more cognitive load to read an inverse condition and then >> invert it again to understand the 'else' condition. >> >> Signed-off-by: Joe Stringer > > It's also somewhat od

Re: [ovs-dev] [PATCH 2/2] ofproto: Clean up style in ofproto_flow_mod_learn.

2017-03-17 Thread Ben Pfaff
On Fri, Mar 17, 2017 at 11:38:35AM -0700, Joe Stringer wrote: > It's slightly more cognitive load to read an inverse condition and then > invert it again to understand the 'else' condition. > > Signed-off-by: Joe Stringer It's also somewhat odd to handle the error condition before the common cas

[ovs-dev] [PATCH 2/2] ofproto: Clean up style in ofproto_flow_mod_learn.

2017-03-17 Thread Joe Stringer
It's slightly more cognitive load to read an inverse condition and then invert it again to understand the 'else' condition. Signed-off-by: Joe Stringer --- ofproto/ofproto.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index c6d8