Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-09-18 Thread Greg Rose
] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key On 09/08/2017 06:35 AM, Weglicki, MichalX wrote: Greg, Patch is rebased and sent to mailing list as V3 (Last patch was supposed to be V2 - Przemek by accident sent it again as V1). Br, Michal. Michal, I'm not

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-09-18 Thread Weglicki, MichalX
Hi Greg - comments inline marked [MW]. > -Original Message- > From: Greg Rose [mailto:gvrose8...@gmail.com] > Sent: Saturday, September 16, 2017 12:45 AM > To: Weglicki, MichalX > Cc: d...@openvswitch.org; Darrell Ball > Subject: Re: [ovs-dev] [PATCH 2/2] ofpro

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-09-15 Thread Greg Rose
On 09/08/2017 06:35 AM, Weglicki, MichalX wrote: Greg, Patch is rebased and sent to mailing list as V3 (Last patch was supposed to be V2 - Przemek by accident sent it again as V1). Br, Michal. Michal, I'm not sure what has happened but I can't find your V3 patches in my mail but they are i

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-09-08 Thread Greg Rose
: Greg Rose [mailto:gvrose8...@gmail.com] > Sent: Thursday, September 7, 2017 12:02 AM > To: Weglicki, MichalX > Cc: d...@openvswitch.org; Szczerbik, PrzemyslawX > Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key > > On 09/06/201

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-09-08 Thread Weglicki, MichalX
cki, MichalX > Cc: d...@openvswitch.org; Szczerbik, PrzemyslawX > > Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface > Information Elements to flow key > > On 09/06/2017 02:53 AM, Weglicki, MichalX wrote: > > Hey Greg, > > > >

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-09-06 Thread Greg Rose
Greg Rose [mailto:gvrose8...@gmail.com] Sent: Tuesday, August 29, 2017 5:15 PM To: Weglicki, MichalX Cc: d...@openvswitch.org; Szczerbik, PrzemyslawX Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key On 08/29/2017 04:48 AM, Weglicki, MichalX

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-09-06 Thread Greg Rose
ssage- From: Greg Rose [mailto:gvrose8...@gmail.com] Sent: Tuesday, August 29, 2017 5:15 PM To: Weglicki, MichalX Cc: d...@openvswitch.org; Szczerbik, PrzemyslawX Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key On 08/29/2017 04:48 AM, Weg

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-09-06 Thread Weglicki, MichalX
ik, PrzemyslawX > > Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface > Information Elements to flow key > > On 08/29/2017 04:48 AM, Weglicki, MichalX wrote: > > Hello Greg, > > > > Unfortunately Przemek is not available, but I'm more o

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-08-29 Thread Greg Rose
day, August 19, 2017 12:51 AM > To: Szczerbik, PrzemyslawX > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key > > On 08/16/2017 01:54 AM, Szczerbik, PrzemyslawX wrote: >> Hi, >> >> I hav

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-08-29 Thread Weglicki, MichalX
zczerbik, PrzemyslawX > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface > Information Elements to flow key > > On 08/16/2017 01:54 AM, Szczerbik, PrzemyslawX wrote: > > Hi, > > > > I haven't received any feedback on th

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-08-18 Thread Greg Rose
inal Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Szczerbik, PrzemyslawX > Sent: Wednesday, July 26, 2017 12:01 PM > To: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information >

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-08-17 Thread Greg Rose
On 08/16/2017 01:54 AM, Szczerbik, PrzemyslawX wrote: Hi, I haven't received any feedback on this patch for quite some time. Is there anything that I can do to expedite review process? Regards, Przemek [snip] I'll have a look at it over the next few days and see if I can provide some feedb

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-08-16 Thread Szczerbik, PrzemyslawX
f Of Szczerbik, PrzemyslawX > Sent: Wednesday, July 26, 2017 12:01 PM > To: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface > Information > Elements to flow key > > Hi, > > This patch was supposed to be v2, but I forgot to mention that

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-07-26 Thread Szczerbik, PrzemyslawX
Hi, This patch was supposed to be v2, but I forgot to mention that in the subject. Previous version: https://patchwork.ozlabs.org/patch/792730/ Let me know if you want me to re-sent it with a proper version. Regards, Przemek > -Original Message- > From: Szczerbik, PrzemyslawX > Sent: We

[ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-07-26 Thread Przemyslaw Szczerbik
Extend flow key part of data record to include following Information Elements: - ingressInterface - ingressInterfaceType - egressInterface - egressInterfaceType - interfaceName - interfaceDescription In case of input sampling we don't have information about egress port. Define templates depending