Re: [ovs-dev] [PATCH 2/2] ovsschema: Avoid using 'protected' as variable name

2017-12-04 Thread Yi-Hung Wei
> We can't change the name of the "protected" column in the database > schema, because that breaks backward compatibility. Another approach > would be to make ovsdb-idlc use a different name for columns whose names > are C or C++ keywords; for example, it could append an underscore. Hi Ben,

Re: [ovs-dev] [PATCH 2/2] ovsschema: Avoid using 'protected' as variable name

2017-12-01 Thread Ben Pfaff
On Thu, Nov 30, 2017 at 11:11:51AM -0800, Yi-Hung Wei wrote: > In C++, 'protected' is a keyword. This patch renames 'protected' > to 'is_protected' in a couple files so that C++ compiler will > not get confused. > > Signed-off-by: Yi-Hung Wei Thanks for working on this.

[ovs-dev] [PATCH 2/2] ovsschema: Avoid using 'protected' as variable name

2017-11-30 Thread Yi-Hung Wei
In C++, 'protected' is a keyword. This patch renames 'protected' to 'is_protected' in a couple files so that C++ compiler will not get confused. Signed-off-by: Yi-Hung Wei --- ofproto/ofproto-dpif.c | 10 +- ofproto/ofproto.h | 2 +- vswitchd/bridge.c