Re: [ovs-dev] [PATCH 2/3] ovsdb-idl: Avoid new expression.

On 8 August 2017 at 00:46, Gao Zhenyu wrote: > Thanks for working on it! > > I think new_ is not a good name. Could you please try to revise it? > like: old --> old_datum >new -->new_datum Sure thing, that's a better name. > BTW, you also need to update 'new'

Re: [ovs-dev] [PATCH 2/3] ovsdb-idl: Avoid new expression.

Thanks for working on it! I think new_ is not a good name. Could you please try to revise it? like: old --> old_datum new -->new_datum BTW, you also need to update 'new' in the description of struct ovsdb_idl_row which in the top of lib/ovsdb-idl-provider.h Thanks Zhenyu Gao

[ovs-dev] [PATCH 2/3] ovsdb-idl: Avoid new expression.

In C++, 'new' is a keyword. If this is used as the name for a field, then C++ compilers can get confused about the context and fail to compile references to such fields. Rename the field to 'new_' to avoid this issue. Signed-off-by: Joe Stringer --- lib/ovsdb-data.h | 4