[ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-05-30 Thread Ivan Malov
Manage "transfer" flows via the corresponding mechanism. Doing so requires that the traffic source be specified explicitly, via the corresponding pattern item. Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- lib/netdev-dpdk.c | 73 --- lib/ne

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-05-30 Thread 0-day Robot
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #41 FILE: lib/netdev-dpdk.c:1126:

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-01 Thread Eli Britstein via dev
- Missing proper handling of the testpmd syntax logging. It changes the used port according to "transfer", but the log still uses netdev_dpdk_get_port_id(). - The usage of the "proxy" port for rte-flow implies that this proxy port is attached to OVS, otherwise it is not "started" and creation of

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-07 Thread Ivan Malov
Hi Eli, On Wed, 1 Jun 2022, Eli Britstein wrote: - Missing proper handling of the testpmd syntax logging. It changes the used port according to "transfer", but the log still uses netdev_dpdk_get_port_id(). Thanks for noticing. I will see to it in the next version. - The usage of the "proxy

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-08 Thread Eli Britstein via dev
Hi Ivan, >-Original Message- >From: Ivan Malov >Sent: Tuesday, June 7, 2022 11:56 PM >To: Eli Britstein >Cc: d...@openvswitch.org; Andrew Rybchenko >; Ilya Maximets ; >Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) >; Stephen Hemminger >; David Marchand >; Gaetan Rivet ; Maxime >Coquel

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-08 Thread Ivan Malov
Hi Eli, On Wed, 8 Jun 2022, Eli Britstein wrote: Hi Ivan, -Original Message- From: Ivan Malov Sent: Tuesday, June 7, 2022 11:56 PM To: Eli Britstein Cc: d...@openvswitch.org; Andrew Rybchenko ; Ilya Maximets ; Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; Stephen Hemminger ; Da

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-08 Thread Eli Britstein via dev
Hi Ivan, >-Original Message- >From: Ivan Malov >Sent: Wednesday, June 8, 2022 5:46 PM >To: Eli Britstein >Cc: d...@openvswitch.org; Andrew Rybchenko >; Ilya Maximets ; >Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) >; Stephen Hemminger >; David Marchand >; Gaetan Rivet ; Maxime >Coque

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-08 Thread Ivan Malov
Hi Eli, On Wed, 8 Jun 2022, Eli Britstein wrote: Hi Ivan, -Original Message- From: Ivan Malov Sent: Wednesday, June 8, 2022 5:46 PM To: Eli Britstein Cc: d...@openvswitch.org; Andrew Rybchenko ; Ilya Maximets ; Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; Stephen Hemminger ; D

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-08 Thread Eli Britstein via dev
Hi Ivan, >-Original Message- >From: Ivan Malov >Sent: Wednesday, June 8, 2022 10:02 PM >To: Eli Britstein >Cc: d...@openvswitch.org; Andrew Rybchenko >; Ilya Maximets ; >Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) >; Stephen Hemminger >; David Marchand >; Gaetan Rivet ; Maxime >Coqu

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-07-20 Thread Ivan Malov
Hi Eli, Thank you for your review efforts. Please find the new version: http://patchwork.ozlabs.org/project/openvswitch/patch/20220720121823.2497727-4-ivan.ma...@oktetlabs.ru/ It cares about the detach scenario we've been talking about. And it cares about port ID logging for transfer flows, too