Re: [ovs-dev] [PATCH 3/3] tests: Ignore options order in dhcpv4 ovn test.

2016-12-23 Thread Balazs Nemeth
>On 14/12/2016 06:38, "Balazs Nemeth" wrote: > >>>On 12/12/2016 13:14, "Ben Pfaff" wrote: >>> On Thu, Dec 08, 2016 at 06:50:32PM -0800, Daniele Di Proietto wrote: > The order of the options in the packet generated by ovs-controller > depends on the hash function. I believe that murmu

Re: [ovs-dev] [PATCH 3/3] tests: Ignore options order in dhcpv4 ovn test.

2016-12-14 Thread Daniele Di Proietto
On 14/12/2016 06:38, "Balazs Nemeth" wrote: >>On 12/12/2016 13:14, "Ben Pfaff" wrote: >> >>>On Thu, Dec 08, 2016 at 06:50:32PM -0800, Daniele Di Proietto wrote: The order of the options in the packet generated by ovs-controller depends on the hash function. I believe that murmur

Re: [ovs-dev] [PATCH 3/3] tests: Ignore options order in dhcpv4 ovn test.

2016-12-14 Thread Balazs Nemeth
>On 12/12/2016 13:14, "Ben Pfaff" mailto:b...@ovn.org>> wrote: > >>On Thu, Dec 08, 2016 at 06:50:32PM -0800, Daniele Di Proietto wrote: >>> The order of the options in the packet generated by ovs-controller >>> depends on the hash function. I believe that murmur hash (our default) >>> produces dif

Re: [ovs-dev] [PATCH 3/3] tests: Ignore options order in dhcpv4 ovn test.

2016-12-12 Thread Daniele Di Proietto
On 12/12/2016 13:14, "Ben Pfaff" wrote: >On Thu, Dec 08, 2016 at 06:50:32PM -0800, Daniele Di Proietto wrote: >> The order of the options in the packet generated by ovs-controller >> depends on the hash function. I believe that murmur hash (our default) >> produces different outputs dependi

Re: [ovs-dev] [PATCH 3/3] tests: Ignore options order in dhcpv4 ovn test.

2016-12-12 Thread Ben Pfaff
On Thu, Dec 08, 2016 at 06:50:32PM -0800, Daniele Di Proietto wrote: > The order of the options in the packet generated by ovs-controller > depends on the hash function. I believe that murmur hash (our default) > produces different outputs depending on the endianness of the system. > > This commi

[ovs-dev] [PATCH 3/3] tests: Ignore options order in dhcpv4 ovn test.

2016-12-08 Thread Daniele Di Proietto
The order of the options in the packet generated by ovs-controller depends on the hash function. I believe that murmur hash (our default) produces different outputs depending on the endianness of the system. This commit fixes the test by reordering the options in the packet before checking them.