Re: [ovs-dev] [PATCH 3/5] ovsdb: transaction: Don't try to diff unchanged columns.

2024-01-09 Thread Ilya Maximets
On 1/5/24 16:09, Mike Pattrick wrote: > On Fri, Jan 5, 2024 at 9:30 AM Ilya Maximets wrote: >> >> On 12/29/23 17:28, Mike Pattrick wrote: >>> On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: While reassessing weak references the code attempts to collect added and removed

Re: [ovs-dev] [PATCH 3/5] ovsdb: transaction: Don't try to diff unchanged columns.

2024-01-05 Thread Mike Pattrick
On Fri, Jan 5, 2024 at 9:30 AM Ilya Maximets wrote: > > On 12/29/23 17:28, Mike Pattrick wrote: > > On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: > >> > >> While reassessing weak references the code attempts to collect added > >> and removed atoms, even if the column didn't change. In

Re: [ovs-dev] [PATCH 3/5] ovsdb: transaction: Don't try to diff unchanged columns.

2024-01-05 Thread Ilya Maximets
On 12/29/23 17:28, Mike Pattrick wrote: > On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: >> >> While reassessing weak references the code attempts to collect added >> and removed atoms, even if the column didn't change. In case the >> column contains a large set, it may take significant

Re: [ovs-dev] [PATCH 3/5] ovsdb: transaction: Don't try to diff unchanged columns.

2023-12-29 Thread Mike Pattrick
On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: > > While reassessing weak references the code attempts to collect added > and removed atoms, even if the column didn't change. In case the > column contains a large set, it may take significant amount of time > to process. > > Add a check for

[ovs-dev] [PATCH 3/5] ovsdb: transaction: Don't try to diff unchanged columns.

2023-12-17 Thread Ilya Maximets
While reassessing weak references the code attempts to collect added and removed atoms, even if the column didn't change. In case the column contains a large set, it may take significant amount of time to process. Add a check for the column actually being changed either by removing references to