Re: [ovs-dev] [PATCH 3/7] userspace: Switching of L3 packets in L2 pipeline

2017-03-07 Thread Ben Pfaff
On Mon, Mar 06, 2017 at 12:37:11AM +, Jan Scheurich wrote: > > I see that match_format() prints packet_type as a hex number. I doubt > > that's the best for human consumption. At the very least, it seems like > > it's better printed as a pair of numbers, and probably it would be more > > frie

Re: [ovs-dev] [PATCH 3/7] userspace: Switching of L3 packets in L2 pipeline

2017-03-05 Thread Jan Scheurich
> Please don't add comments about changes, like this one. Readers should > not have to understand the history to understand the code: > +if (put->flags & DPIF_FP_MODIFY) { > +/* Removed the additional check > + * flow_equal(&match.flow, &netdev_flow->flow) as a) the

Re: [ovs-dev] [PATCH 3/7] userspace: Switching of L3 packets in L2 pipeline

2017-03-03 Thread Ben Pfaff
On Fri, Feb 03, 2017 at 10:40:09AM +, Jan Scheurich wrote: > Ports have a new layer3 attribute if they send/receive L3 packets. > > The packet_type included in structs dp_packet and flow is considered in > ofproto-dpif. The classical L2 match fields (dl_src, dl_dst, dl_type, and > vlan_tci, vl

[ovs-dev] [PATCH 3/7] userspace: Switching of L3 packets in L2 pipeline

2017-02-03 Thread Jan Scheurich
Ports have a new layer3 attribute if they send/receive L3 packets. The packet_type included in structs dp_packet and flow is considered in ofproto-dpif. The classical L2 match fields (dl_src, dl_dst, dl_type, and vlan_tci, vlan_vid, vlan_pcp) now have Ethernet as pre-requisite. A dummy ethernet h