Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization.

2018-08-15 Thread Ben Pfaff
On Wed, Aug 01, 2018 at 03:23:38PM +0100, Ian Stokes wrote: > On 7/12/2018 10:55 PM, Ben Pfaff wrote: > >The macros are hard to read. This makes it a little more readable. > > > > Thanks for this Ben, one minor comment below. > > >Signed-off-by: Ben Pfaff > >--- > > configure.ac | 1

Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization.

2018-08-02 Thread Chandran, Sugesh
Hi Ian/Ben , Please find my comments below. Regards _Sugesh > -Original Message- > From: Stokes, Ian > Sent: Wednesday, August 1, 2018 3:24 PM > To: Ben Pfaff ; d...@openvswitch.org > Cc: Chandran, Sugesh > Subject: Re: [ovs-dev] [PATCH 5/5] netdev: Clean up cl

Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization.

2018-08-01 Thread Ian Stokes
On 7/12/2018 10:55 PM, Ben Pfaff wrote: The macros are hard to read. This makes it a little more readable. Thanks for this Ben, one minor comment below. Signed-off-by: Ben Pfaff --- configure.ac | 1 + lib/netdev-dpdk.c | 235 -- lib/netde

Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization.

2018-07-16 Thread Yifeng Sun
Thanks. Looks good to me. Reviewed-by: Yifeng Sun On Thu, Jul 12, 2018 at 2:55 PM, Ben Pfaff wrote: > The macros are hard to read. This makes it a little more readable. > > Signed-off-by: Ben Pfaff > --- > configure.ac | 1 + > lib/netdev-dpdk.c | 235

[ovs-dev] [PATCH 5/5] netdev: Clean up class initialization.

2018-07-12 Thread Ben Pfaff
The macros are hard to read. This makes it a little more readable. Signed-off-by: Ben Pfaff --- configure.ac | 1 + lib/netdev-dpdk.c | 235 -- lib/netdev-dummy.c| 134 lib/netdev-linux.c| 340 +++---