Re: [ovs-dev] [PATCH RESEND v4] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2023-07-03 Thread Ilya Maximets
On 7/3/23 18:10, David Marchand wrote: > On Thu, Jun 29, 2023 at 9:43 PM Ilya Maximets wrote: >> >> On 6/20/23 13:26, David Marchand wrote: >>> At some point in OVS history, some virtio features were announced as >>> supported (ECN and UFO virtio features). >>> >>> The userspace TSO code, which

Re: [ovs-dev] [PATCH RESEND v4] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2023-07-03 Thread David Marchand
On Thu, Jun 29, 2023 at 9:43 PM Ilya Maximets wrote: > > On 6/20/23 13:26, David Marchand wrote: > > At some point in OVS history, some virtio features were announced as > > supported (ECN and UFO virtio features). > > > > The userspace TSO code, which has been added later, does not support > >

Re: [ovs-dev] [PATCH RESEND v4] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2023-06-29 Thread Ilya Maximets
On 6/20/23 13:26, David Marchand wrote: > At some point in OVS history, some virtio features were announced as > supported (ECN and UFO virtio features). > > The userspace TSO code, which has been added later, does not support > those features and tries to disable them. > > This breaks OVS

Re: [ovs-dev] [PATCH RESEND v4] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2023-06-29 Thread Simon Horman
On Tue, Jun 20, 2023 at 01:26:38PM +0200, David Marchand wrote: > At some point in OVS history, some virtio features were announced as > supported (ECN and UFO virtio features). > > The userspace TSO code, which has been added later, does not support > those features and tries to disable them. >

[ovs-dev] [PATCH RESEND v4] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2023-06-20 Thread David Marchand
At some point in OVS history, some virtio features were announced as supported (ECN and UFO virtio features). The userspace TSO code, which has been added later, does not support those features and tries to disable them. This breaks OVS upgrades: if an existing VM already negotiated such