Re: [ovs-dev] [PATCH V2] compat:inet_frag.h: Check for frag_percpu_counter_batch

2018-01-23 Thread Gregory Rose
On 1/23/2018 1:07 PM, Justin Pettit wrote: On Jan 23, 2018, at 12:01 PM, Gregory Rose wrote: On 1/23/2018 12:00 PM, Justin Pettit wrote: On Jan 5, 2018, at 11:30 AM, Greg Rose wrote: +#ifdef frag_percpu_counter_batch ... +#else /*

Re: [ovs-dev] [PATCH V2] compat:inet_frag.h: Check for frag_percpu_counter_batch

2018-01-23 Thread Justin Pettit
> On Jan 23, 2018, at 12:34 PM, Ben Pfaff wrote: > > On Tue, Jan 23, 2018 at 12:00:20PM -0800, Justin Pettit wrote: >> >> >>> On Jan 5, 2018, at 11:30 AM, Greg Rose wrote: >>> >>> +#ifdef frag_percpu_counter_batch >>> ... >>> +#else /*

Re: [ovs-dev] [PATCH V2] compat:inet_frag.h: Check for frag_percpu_counter_batch

2018-01-23 Thread Justin Pettit
> On Jan 23, 2018, at 12:01 PM, Gregory Rose wrote: > > On 1/23/2018 12:00 PM, Justin Pettit wrote: >> >>> On Jan 5, 2018, at 11:30 AM, Greg Rose wrote: >>> >>> +#ifdef frag_percpu_counter_batch >>> ... >>> +#else /* frag_percpu_counter_batch */ >>

Re: [ovs-dev] [PATCH V2] compat:inet_frag.h: Check for frag_percpu_counter_batch

2018-01-23 Thread Ben Pfaff
On Tue, Jan 23, 2018 at 12:00:20PM -0800, Justin Pettit wrote: > > > > On Jan 5, 2018, at 11:30 AM, Greg Rose wrote: > > > > +#ifdef frag_percpu_counter_batch > > ... > > +#else /* frag_percpu_counter_batch */ > > This is kind of a nit, but I would have thought this

Re: [ovs-dev] [PATCH V2] compat:inet_frag.h: Check for frag_percpu_counter_batch

2018-01-23 Thread Gregory Rose
On 1/23/2018 12:00 PM, Justin Pettit wrote: On Jan 5, 2018, at 11:30 AM, Greg Rose wrote: +#ifdef frag_percpu_counter_batch ... +#else /* frag_percpu_counter_batch */ This is kind of a nit, but I would have thought this "#else" comment would be

Re: [ovs-dev] [PATCH V2] compat:inet_frag.h: Check for frag_percpu_counter_batch

2018-01-23 Thread Justin Pettit
> On Jan 5, 2018, at 11:30 AM, Greg Rose wrote: > > +#ifdef frag_percpu_counter_batch > ... > +#else /* frag_percpu_counter_batch */ This is kind of a nit, but I would have thought this "#else" comment would be "!frag_percpu_counter_batch", since that's the case when

[ovs-dev] [PATCH V2] compat:inet_frag.h: Check for frag_percpu_counter_batch

2018-01-05 Thread Greg Rose
Fix up the compat layer to check for frag_percpu_counter_batch and if not present then use atomic_sub and atomic_add as per the backport in the 3.16.50 LTS kernel. Fixes compile errors on 3.16 series kernels from 3.16.50 on. Signed-off-by: Greg Rose --- V2 - Fix typo ---